Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI wheels build #178

Merged
merged 9 commits into from
Jun 29, 2023
Merged

CI wheels build #178

merged 9 commits into from
Jun 29, 2023

Conversation

NikoOinonen
Copy link
Collaborator

@NikoOinonen NikoOinonen commented Jun 28, 2023

fixes #106

Adds a job to the PyPI CI workflow that builds wheels for all platforms (64-bit).

The job generates a separate wheel for every Python version >=3.7. I don't think there is actually any difference in the wheels between the different Python versions, but I didn't find a way to just generate one. I tested that the wheel build works, but I didn't test how it interacts with the upload to PyPI.

The minimum Python version had to be bumped up to 3.7 because there does not exist a new-enough version of setuptools for 3.6.

Removed the lookup for MSVC variables on Windows because there is a Github action that does it better.

@NikoOinonen
Copy link
Collaborator Author

Related to #106, but let's not close it until there is a release on PyPI.

Copy link
Collaborator

@yakutovicha yakutovicha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a minor change request. The rest looks good.

After this is merged, I suggest we try to make a patch release 0.2.1 and see if things work.

.github/workflows/publish.yml Show resolved Hide resolved
Copy link
Collaborator

@yakutovicha yakutovicha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool 😎 !

@NikoOinonen NikoOinonen merged commit 8c46a21 into main Jun 29, 2023
10 checks passed
@NikoOinonen NikoOinonen deleted the ci-build branch June 29, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build wheels for different operating systems.
2 participants