Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the docker container. #181

Merged
merged 17 commits into from
Jul 21, 2023
Merged

Update the docker container. #181

merged 17 commits into from
Jul 21, 2023

Conversation

yakutovicha
Copy link
Collaborator

@yakutovicha yakutovicha commented Jul 21, 2023

Slight update of the Dockerfile to be in sync with the latest developments of ppafm.

@yakutovicha yakutovicha marked this pull request as draft July 21, 2023 09:47
@NikoOinonen
Copy link
Collaborator

I was just testing this on my computer, and got the same PermissionError: [Errno 13] Permission denied: 'FFLJ_x.xsf as in the CI test. For me the problem was that the example folder did not have write permission for other users. When I set the 777 permissions, then it worked.

@yakutovicha
Copy link
Collaborator Author

I was just testing this on my computer, and got the same PermissionError: [Errno 13] Permission denied: 'FFLJ_x.xsf as in the CI test. For me the problem was that the example folder did not have write permission for other users. When I set the 777 permissions, then it worked.

Yes, I just tried that approach too and added to the test.

@yakutovicha
Copy link
Collaborator Author

By the way, @NikoOinonen, do you have a win machine? That would be great if someone could test it on win too.

@NikoOinonen
Copy link
Collaborator

Sure, I can try on Windows as well.

@NikoOinonen
Copy link
Collaborator

Also getting that setuptools error now. I have seen this before, when pip for some reason priorities the Ubuntu system setuptools installation which is some ancient version. It can be fixed in a kind of brute force way by removing the default setuptools installation and replacing it like here: https://askubuntu.com/questions/683601/how-to-upgrade-python-setuptools-12-2-on-ubuntu-15-04/683730#683730

@yakutovicha
Copy link
Collaborator Author

@NikoOinonen I finally managed to simplify the Docker file and make things work. The PR is ready for your review and testing.

@yakutovicha yakutovicha marked this pull request as ready for review July 21, 2023 13:37
@yakutovicha
Copy link
Collaborator Author

yakutovicha commented Jul 21, 2023

Maybe we should automatically test the docker image for different operating systems as well.

What do you think @NikoOinonen?

@yakutovicha
Copy link
Collaborator Author

Well, I tried and failed. I don't have too much interest and time to work on this further. Let's review/merge it as it is. We can always add more stuff later.

@NikoOinonen
Copy link
Collaborator

It seems to work in both Linux and Windows. On Windows the only difference is that in cmd PWD does not work, so you run docker with

docker run --rm -v %CD%:/exec ppafm:latest ...

I added a note of that to the wiki.

@NikoOinonen NikoOinonen mentioned this pull request Jul 21, 2023
@yakutovicha yakutovicha merged commit 40f6090 into main Jul 21, 2023
12 checks passed
@yakutovicha yakutovicha deleted the update/docker-container branch July 21, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants