-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the docker container. #181
Conversation
I was just testing this on my computer, and got the same |
Yes, I just tried that approach too and added to the test. |
By the way, @NikoOinonen, do you have a win machine? That would be great if someone could test it on win too. |
Sure, I can try on Windows as well. |
Also getting that setuptools error now. I have seen this before, when pip for some reason priorities the Ubuntu system setuptools installation which is some ancient version. It can be fixed in a kind of brute force way by removing the default setuptools installation and replacing it like here: https://askubuntu.com/questions/683601/how-to-upgrade-python-setuptools-12-2-on-ubuntu-15-04/683730#683730 |
@NikoOinonen I finally managed to simplify the Docker file and make things work. The PR is ready for your review and testing. |
Maybe we should automatically test the docker image for different operating systems as well. What do you think @NikoOinonen? |
Well, I tried and failed. I don't have too much interest and time to work on this further. Let's review/merge it as it is. We can always add more stuff later. |
It seems to work in both Linux and Windows. On Windows the only difference is that in cmd docker run --rm -v %CD%:/exec ppafm:latest ... I added a note of that to the wiki. |
Slight update of the Dockerfile to be in sync with the latest developments of ppafm.