PB-435 Rethink migration #5
Conversation
| table.text('description'); | ||
| table.string('name'); | ||
| table.string('plugin'); | ||
| // @todo: do we want this to be an enum, or leave it open to more statuses? |
There was a problem hiding this comment.
My inclination is to just leave it open so that new plugins created in the main probo project don't also need a sibling PR in this project too.
kleinmp
force-pushed
the
feature/rethink-migration
branch
from
1464ed4
to
4700a6c
Compare
lib/Api.js
Outdated
| @@ -225,6 +225,23 @@ class Api { | |||
| }); | |||
| } | |||
|
|
|||
| updateObject(req, res, next) { | |||
| let self = this; | |||
There was a problem hiding this comment.
@kleinmp @dzink - Your default variable declaration should be const instead of let. In JS, const is still bound by function scope (really any block scope - e.g. var is not bound by if statements but const and let are), it can't leak out of this scope. It does not mean the same thing in JS as it does in PHP or other languages.
The reason to use const by default is to ensure the variable binding remains the same. let can be redefined within a scope, whereas const cannot. Defaulting to const requires you to think about if you want this variable to be reboundable to something different. 95% of the time, you never want to reuse the same variable name within one scope.
No description provided.