Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

epic/FOUR-11496: [PRD] New Script Modal Redesign IT1 #5642

Merged
merged 35 commits into from Nov 29, 2023
Merged

epic/FOUR-11496: [PRD] New Script Modal Redesign IT1 #5642

merged 35 commits into from Nov 29, 2023

Conversation

pmPaulis
Copy link
Contributor

@pmPaulis pmPaulis commented Nov 16, 2023 •
edited

Issue & Reproduction Steps

This feature addresses the common pain point of time-consuming CSS fine-tuning and manual adjustments for design elements like borders and spacing on every page.

Solution

  • The new feature will change the interfaz to create a new Script

How to Test

  • Create a new script

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

ci:deploy
ci:next
ci:package-projects:feature/FOUR-11496

@tokensPM
Copy link

QA server was successfully deployed https://ci-36e6c00df8.eng.processmaker.net

@luNunezProcessmaker
feature/FOUR-12189
7f45cea
@pmPaulis
Merge pull request #5646 from ProcessMaker/feature/FOUR-12189
0b483ae 
feature/FOUR-12189 : FOUR-11498: Create a Accordion component: Add Advanced options - Less Options
@tokensPM
Copy link

QA server was successfully deployed https://ci-36e6c00df8.eng.processmaker.net

@tokensPM
Copy link

QA server was successfully deployed https://ci-36e6c00df8.eng.processmaker.net

@tokensPM
Copy link

QA server was successfully deployed https://ci-36e6c00df8.eng.processmaker.net

@tokensPM
Copy link

QA server was successfully deployed https://ci-36e6c00df8.eng.processmaker.net

@tokensPM
Copy link

QA server was successfully deployed https://ci-36e6c00df8.eng.processmaker.net

@pmPaulis
Merge pull request #5683 from ProcessMaker/bugfix/FOUR-12504
49dd175 
FOUR-12504:It is not possible to recognize the new custom script executor created
@pmPaulis
Merge pull request #5680 from ProcessMaker/bugfix/FOUR-12502
4fa1c34 
QA Observation: Bugfix/FOUR-12502 The fields are not cleared after closing the modal
@tokensPM
Copy link

QA server was successfully deployed https://ci-36e6c00df8.eng.processmaker.net

@processmaker-sonarqube ProcessMaker SonarQube
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@tokensPM
Copy link

QA server was successfully deployed https://ci-36e6c00df8.eng.processmaker.net

1 similar comment
@tokensPM
Copy link

QA server was successfully deployed https://ci-36e6c00df8.eng.processmaker.net

@pmPaulis
Copy link
Contributor Author

The following is a video to explain how will work the PRD

Designer.-.ProcessMaker.mp4

@ryancooley ryancooley merged commit aaaa929 into next Nov 29, 2023
13 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fagubla fagubla fagubla approved these changes

@luNunezProcessmaker luNunezProcessmaker luNunezProcessmaker approved these changes

@CarliPinell CarliPinell Awaiting requested review from CarliPinell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
6 participants
@pmPaulis @tokensPM @fagubla @luNunezProcessmaker @ryancooley @CarliPinell