Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Project Filtering for Admin and Regular Users #5828

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

sanjacornelius
Copy link
Contributor

@sanjacornelius sanjacornelius commented Dec 14, 2023

This PR refactors the project filtering by owner and member if the user is not an admin, allowing admins to view all projects created within the instance. The admin has all capabilities to edit/delete projects.

Solution

  • Refactored project filtering logic for both admin and regular users.

How to Test

  1. Create a user.
  2. Log in as the user and create projects.
  3. Log in as an admin and view projects.
  4. Ensure that the admin can see all projects created by users.
  5. As an admin, create projects.
  6. Log in as a user.
  7. Ensure the users cannot access the admin-created projects that they are not a member of.

Related Tickets & Packages

ci:next
ci:package-projects:story/FOUR-12748
ci:deploy

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

Copy link

@tokensPM
Copy link

QA server was successfully deployed https://ci-eef8f2f81c.eng.processmaker.net

Copy link
Contributor

@mcraeteisha mcraeteisha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@ryancooley ryancooley merged commit ec657d9 into next Dec 15, 2023
12 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants