Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOUR-7157: 34947 - The line input control of type integer or currency, with the required validation, does not recognize 0 as an integer #1626

Merged
merged 5 commits into from
Jul 24, 2024

Conversation

rodriquelca
Copy link
Contributor

@rodriquelca rodriquelca commented Jun 19, 2024

Issue & Reproduction Steps

34947 - The line input control of type integer or currency, with the required validation, does not recognize 0 as an integer
Expected behavior:
The required field should disappear when entering a zero value, because zero is considered an integer.
Actual behavior:
You will see that the required field does not disappear

Solution

  • Improve required logic to support 0 integer
required.mov

How to Test

Test the steps above

  1. Create a form type screen (or import the attached file)
  2. Go to designer tab
  3. Click on the "Screens" option
  4. Click on "+Screen" button
  5. Fill in the fields: name and description
  6. Select "Form" in the Type field
  7. Click on save button
  8. Create 2 "Line Input" control to modeler
  9. Configuring the first line input control
  10. Set the 'data type' of the line input to Currency and Currency Format USD.
  11. Set the line input to required by checking the required checkbox.
  12. Configure the second line input
  13. In "Data type" select "Integer"
  14. In "Validation Rules" add "Required" rule
  15. Click on save button
  16. Click on preview button

-Enter the value zero into the both line input field

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

ci:develop

…, with the required validation, does not recognize 0 as an integer
Copy link

cypress bot commented Jun 19, 2024

Passing run #898 ↗︎

0 266 19 0 Flakiness 0

Details:

FOUR-7157: 34947 - The line input control of type integer or currency, with the ...
Project: screen-builder Commit: 7f12acd52e
Status: Passed Duration: 06:51 💡
Started: Jun 25, 2024 2:44 PM Ended: Jun 25, 2024 2:51 PM

Review all test suite changes for PR #1626 ↗︎

@rodriquelca rodriquelca requested a review from caleeli June 19, 2024 19:05
Copy link

@ryancooley ryancooley merged commit 5716f0a into develop Jul 24, 2024
24 of 27 checks passed
@ryancooley ryancooley deleted the bugfix/FOUR-7157 branch July 24, 2024 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants