Return approval state in API response #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
"Approval state" is a domain concept, and it's not what you are returning. -2 because of poor PR title ;) |
|
Oh, you are returning it. Nvm, I'm -2'ing my previous comment instead. |
waximabbax
reviewed
Jul 1, 2024
|
|
||
| return $this->getResponseFactory()->createJson( [ | ||
| 'approvalTimestamp' => $state->approvalTimestamp, | ||
| 'approver' => $this->getUserNameFromUserId( $state->approverId ), |
There was a problem hiding this comment.
I think it should return UserRealName and not the username since I am actually using user_real_name from user table and if the real name doesn't exist then perhaps maybe username. @malberts @JeroenDeDauw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #54
Also needed to show the new approval details on a page without refresh.