Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setupSkinUserCss is deprecated: skin renders unstyled #202

Closed
jdlrobson opened this issue Nov 6, 2020 · 0 comments
Closed

setupSkinUserCss is deprecated: skin renders unstyled #202

jdlrobson opened this issue Nov 6, 2020 · 0 comments

Comments

@jdlrobson
Copy link
Contributor

Impact: the stylesheet for the skins do not load

To address this you can follow the example here:
https://gerrit.wikimedia.org/r/c/mediawiki/skins/Nimbus/+/639875
Let me know if you need any help!
jdlrobson added a commit to jdlrobson/chameleon that referenced this issue Dec 31, 2020
@jdlrobson
Add style loading compatibility for 1.35
726580c 
Using wgVersion determine the current version of MediaWiki.
In the case of < 1.35 use initPage (has been around since 1.31)
instead of setupSkinUserCss (deprecated since 1.31)

For > 1.35 use skin styles registration via options in
SetupAfterCache.

When support is dropped for < 1.35 all the version guarded
code can be dropped.

Fixes: ProfessionalWiki#202
Fixes: ProfessionalWiki#110
@jdlrobson jdlrobson mentioned this issue Dec 31, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jdlrobson