No need to remove legacy module in 1.35 #115
Conversation
What problems did you run into? |
|
Just with my local setup. Didn't try too hard. Some issues with the composer install. Said missing dependency mediawiki/mediawiki or something like that. |
|
Travis is complaining about same error I was running into so I feel a little better :) |
|
Yeah you can't just do composer install in a clone of this repo. It needs to be installed into MW. So all good. We do not want to drop support with MW < 1.35 yet, so this PR will sit here a while. It is however appreciated. |
|
@JeroenDeDauw it would be possible to support 1.35 and the current version with a few checks of wgVersion. Would an amended patch to that effect unstall this? |
|
Yes. Stalled only because it breaks compat with MW 1.31 |
Using wgVersion determine the current version of MediaWiki. In the case of < 1.35 use initPage (has been around since 1.31) instead of setupSkinUserCss (deprecated since 1.31) For > 1.35 use skin styles registration via options in SetupAfterCache. When support is dropped for < 1.35 all the version guarded code can be dropped. Fixes: ProfessionalWiki#202 Fixes: ProfessionalWiki#110
|
I've amended this to support < 1.35. Have also fixed #202 while I'm here since it's related :) |
(disclaimer: untested - couldn't get this working locally)
This module is no longer added to skins so you shouldn't need to remove this module provided you bump the mediawiki dependency
Fixes: #110