Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken: Injecting calls to 2 different method within the same module #10

Closed
schrnz opened this issue Dec 22, 2017 · 0 comments · Fixed by #23
Closed

Broken: Injecting calls to 2 different method within the same module #10

schrnz opened this issue Dec 22, 2017 · 0 comments · Fixed by #23
Labels

Comments

@schrnz
Copy link
Member

schrnz commented Dec 22, 2017

When using an artist pass to inject calls to 2 different codelib methods into the same target method, the second call (by the order defined in the artist pass) will trigger the invocation of the clone method on the codelib instead. Everything works perfectly well if the injected calls invoke the same codelib method...

As of now, it is completely unclear to me why this happens. Splitting the injections into 2 distinct modules works perfectly fine, so right now this is a valid workaround. However, this is obviously a weird bug and in order to avoid code duplication, we should be able to have more than one injection per artist pass.

@schrnz schrnz added the bug label Dec 22, 2017
alfink added a commit to alfink/ARTist that referenced this issue Aug 16, 2018
alfink added a commit to alfink/ARTist that referenced this issue Aug 16, 2018
@alfink alfink mentioned this issue Aug 16, 2018
alfink added a commit to alfink/ARTist that referenced this issue Aug 16, 2018
alfink added a commit to alfink/ARTist that referenced this issue Aug 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant