Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

713-gradcam #1303

Merged
merged 6 commits into from
Dec 2, 2020
Merged

713-gradcam #1303

merged 6 commits into from
Dec 2, 2020

Conversation

wyli
Copy link
Contributor

@wyli wyli commented Nov 30, 2020

Signed-off-by: Wenqi Li wenqil@nvidia.com

Fixes #713; fixes #1212

Description

visualisations with class activation maps
added CAM/GradCAM/GradCAM++

Status

ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh --codeformat --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

monai/visualize/class_activation_maps.py Outdated Show resolved Hide resolved
monai/visualize/class_activation_maps.py Outdated Show resolved Hide resolved
@wyli
Copy link
Contributor Author

wyli commented Nov 30, 2020

thanks @ahatamiz I've updated the modules, I'll add a few unit tests. do you have a use case in 3D by any chance?

@ahatamiz
Copy link
Contributor

thanks @ahatamiz I've updated the modules, I'll add a few unit tests. do you have a use case in 3D by any chance?

Great work @wyli ! I don't have a trained 3D use case right now.. but maybe we can use one of the COVID models for classification ?

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
Copy link
Contributor Author

wyli commented Dec 1, 2020

/integration-test
added modules and tests for:

  • cam
    cam
  • gradcam
    gradcam
  • gradcam++
    gradcam++

@wyli wyli marked this pull request as ready for review December 1, 2020 18:31
@wyli wyli requested review from Nic-Ma and ericspod December 1, 2020 18:31
Copy link
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your great work, this new feature looks good to me.
@ericspod do you have any more comments from a researcher's view?

Thanks.

@Nic-Ma
Copy link
Contributor

Nic-Ma commented Dec 2, 2020

Hi @wyli , and BTW, I think this is very cool a new feature, could you please help also develop a tutorial notebook for it?

Thanks.

@wyli
Copy link
Contributor Author

wyli commented Dec 2, 2020

Hi @wyli , and BTW, I think this is very cool a new feature, could you please help also develop a tutorial notebook for it?

Thanks.

that would be nice but I don't have a good quality 3d model, do you have access to any classification model?

@Nic-Ma
Copy link
Contributor

Nic-Ma commented Dec 2, 2020

Can we use IXI dataset to train a model? Actually, I am curious which part of the feature map indicates the gender in IXI.
Thanks.

@wyli
Copy link
Contributor Author

wyli commented Dec 2, 2020

Can we use IXI dataset to train a model? Actually, I am curious which part of the feature map indicates the gender in IXI.
Thanks.

the training is a short demo with only a few examples, don't think visualisation will make sense..

@Nic-Ma
Copy link
Contributor

Nic-Ma commented Dec 2, 2020

OK, then I don't have any better dataset for reference. Maybe @ericspod knows more?
Thanks.

@wyli wyli merged commit fb37348 into Project-MONAI:master Dec 2, 2020
@wyli
Copy link
Contributor Author

wyli commented Dec 2, 2020

I create a ticket to track the progress of the demo Project-MONAI/tutorials#76

@wyli wyli deleted the 713-gradcam branch April 12, 2021 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Maps - GradCam GradCam
3 participants