Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create AE/src/dest APIs to return 409 if entity already exists #182

Merged
merged 4 commits into from
Sep 29, 2022

Conversation

mocsharp
Copy link
Collaborator

@mocsharp mocsharp commented Sep 27, 2022

Description

Fixes #180 .

Returns HTTP 409 Conflict if users try to add a listening AE title/DICOM source/ DICOM destination that already exists.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.
  • User guide updated.
  • I have updated the changelog

Signed-off-by: Victor Chang <vicchang@nvidia.com>
@mocsharp mocsharp added the bug Something isn't working label Sep 27, 2022
@mocsharp mocsharp added this to the 0.3.2 milestone Sep 27, 2022
@mocsharp mocsharp self-assigned this Sep 27, 2022
@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Merging #182 (bb3492f) into develop (fe56aca) will increase coverage by 0.03811%.
The diff coverage is 88.75000%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             develop        #182         +/-   ##
===================================================
+ Coverage   92.89748%   92.93559%   +0.03811%     
===================================================
  Files            262         263          +1     
  Lines          14699       14750         +51     
  Branches         787         785          -2     
===================================================
+ Hits           13655       13708         +53     
+ Misses           805         804          -1     
+ Partials         239         238          -1     
Flag Coverage Δ
unittests 92.93559% <88.75000%> (+0.03811%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...InformaticsGateway/Common/ObjectExistsException.cs 25.00000% <25.00000%> (ø)
...icsGateway/Services/Http/MonaiAeTitleController.cs 91.37931% <75.00000%> (+0.30787%) ⬆️
...csGateway/Services/Http/SourceAeTitleController.cs 92.15686% <75.00000%> (+4.40175%) ⬆️
...eway/Services/Http/DestinationAeTitleController.cs 92.15686% <83.33333%> (+4.40175%) ⬆️
.../Services/Http/DestinationAeTitleControllerTest.cs 100.00000% <100.00000%> (ø)
...y/Test/Services/Http/MonaiAeTitleControllerTest.cs 100.00000% <100.00000%> (ø)
.../Test/Services/Http/SourceAeTitleControllerTest.cs 100.00000% <100.00000%> (ø)
...maticsGateway/Services/HealthLevel7/MllpService.cs 77.38095% <0.00000%> (-2.38095%) ⬇️
...ateway/Services/Connectors/DataRetrievalService.cs 80.36364% <0.00000%> (-0.72727%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe56aca...bb3492f. Read the comment docs.

Signed-off-by: Victor Chang <vicchang@nvidia.com>
mocsharp and others added 2 commits September 28, 2022 10:59
Signed-off-by: Victor Chang <vicchang@nvidia.com>
Signed-off-by: Victor Chang <vicchang@nvidia.com>
@mocsharp mocsharp merged commit 47f4dec into develop Sep 29, 2022
@mocsharp mocsharp deleted the vchang/gh-180 branch September 29, 2022 01:58
@github-actions
Copy link

🎉 This issue has been resolved in version 0.3.2 🎉

The release is available on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement 409 Conflict where AETitle exists - POST /config/ae
2 participants