Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RabbitMQ] Attempt to use a faulted connection #78

Closed
mocsharp opened this issue Sep 30, 2022 · 1 comment · Fixed by #79
Closed

[RabbitMQ] Attempt to use a faulted connection #78

mocsharp opened this issue Sep 30, 2022 · 1 comment · Fixed by #79
Assignees
@mocsharp
Labels
bug Something isn't working
Milestone
0.1.6

Comments

@mocsharp
Copy link
Collaborator

Description

Project-MONAI/monai-deploy-informatics-gateway#184

If the RabbitMQ service becomes unavailable for a moment and attempts to acquire a connection through the factory, the factory would crash because the stored connection object is already faulted. The fix is to make sure that the Lazy value is successfully created before checking to see if the connection is still open.

Steps to reproduce

Please share a clear and concise description of the problem.

  1. Start the application, publish a message
  2. Kill RMQ
  3. Send another message
  4. Start RMQ
  5. Send another message
    ...

Expected behavior

The 3rd message successfully sends.

Actual behavior

The 3rd message failed to send and the application crahes.
@mocsharp mocsharp added the bug Something isn't working label Sep 30, 2022
@mocsharp mocsharp self-assigned this Sep 30, 2022
@mocsharp mocsharp added this to the 0.1.6 milestone Sep 30, 2022
mocsharp added a commit that referenced this issue Sep 30, 2022
@mocsharp
gh-78 Makes sure the connection is created before accessing
95809fc 
Signed-off-by: Victor Chang <vicchang@nvidia.com>
@mocsharp mocsharp mentioned this issue Sep 30, 2022
Merged
5 tasks
mocsharp added a commit that referenced this issue Oct 1, 2022
@mocsharp
Merge pull request #79 from Project-MONAI/vchang/gh-78
6cbbf23 
Ensures the connection is created before accessing
@github-actions
Copy link

github-actions bot commented Oct 3, 2022

🎉 This issue has been resolved in version 0.1.6 🎉

The release is available on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mocsharp mocsharp

Labels
bug Something isn't working
Projects
None yet
Milestone
0.1.6
Development

Successfully merging a pull request may close this issue.

Ensures the connection is created before accessing Project-MONAI/monai-deploy-messaging
1 participant
@mocsharp