Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensures the connection is created before accessing #79

Merged
merged 2 commits into from
Oct 1, 2022
Merged

Conversation

mocsharp
Copy link
Collaborator

@mocsharp mocsharp commented Sep 30, 2022

Description

Fixes #78 .

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.

Signed-off-by: Victor Chang <vicchang@nvidia.com>
@mocsharp mocsharp added the bug Something isn't working label Sep 30, 2022
@mocsharp mocsharp added this to the 0.1.6 milestone Sep 30, 2022
@mocsharp mocsharp self-assigned this Sep 30, 2022
@mocsharp mocsharp changed the title Makes sure the connection is created before accessing Ensures the connection is created before accessing Sep 30, 2022
Signed-off-by: Victor Chang <vicchang@nvidia.com>
@codecov
Copy link

codecov bot commented Sep 30, 2022

Codecov Report

Merging #79 (586cb5c) into develop (f48d876) will decrease coverage by 0.21312%.
The diff coverage is 0.00000%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             develop         #79         +/-   ##
===================================================
- Coverage   83.96947%   83.75635%   -0.21313%     
===================================================
  Files             41          41                 
  Lines           1179        1182          +3     
  Branches          68          68                 
===================================================
  Hits             990         990                 
- Misses           165         168          +3     
  Partials          24          24                 
Flag Coverage Δ
unittests 83.75635% <0.00000%> (-0.21313%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Plugins/RabbitMQ/RabbitMqConnectionFactory.cs 0.00000% <0.00000%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f48d876...586cb5c. Read the comment docs.

@mocsharp mocsharp merged commit 6cbbf23 into develop Oct 1, 2022
@mocsharp mocsharp deleted the vchang/gh-78 branch October 1, 2022 21:13
@github-actions
Copy link

github-actions bot commented Oct 3, 2022

🎉 This issue has been resolved in version 0.1.6 🎉

The release is available on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RabbitMQ] Attempt to use a faulted connection
2 participants