fix not found workflow response (#435)

* fix not found workflow response Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com> * fix test Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com> * Changed error assertion to look for basic layout of errors as well as content Signed-off-by: RemakingEden <joss.sparkes@gmail.com> Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com> Signed-off-by: RemakingEden <joss.sparkes@gmail.com> Co-authored-by: RemakingEden <joss.sparkes@gmail.com> Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com>
Project-MONAI · Sep 22, 2022 · 034ea3a · 034ea3a
1 parent 1458197
commit 034ea3a
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/src/WorkflowManager/WorkflowManager/Controllers/WorkflowsController.cs b/src/WorkflowManager/WorkflowManager/Controllers/WorkflowsController.cs
@@ -189,7 +189,7 @@ public async Task<IActionResult> UpdateAsync([FromBody] Workflow workflow, [From
                 {
                     _logger.LogDebug($"{nameof(UpdateAsync)} - Failed to find workflow with Id: {id}");
 
-                    return NotFound($"Failed to find workflow with Id: {id}");
+                    return Problem($"Failed to find workflow with Id: {id}", $"/workflows/{id}", NotFound);
                 }
 
                 return StatusCode(StatusCodes.Status201Created, new CreateWorkflowResponse(workflowId));

diff --git a/...rationTests/WorkflowExecutor.IntegrationTests/StepDefinitions/CommonApiStepDefinitions.cs b/...rationTests/WorkflowExecutor.IntegrationTests/StepDefinitions/CommonApiStepDefinitions.cs
@@ -67,7 +67,8 @@ public void GivenIHaveTaskRequestBody(string name)
 
         [Then(@"I will recieve the error message (.*)")]
         public void ThenIWillRecieveTheCorrectErrorMessage(string message)
-        {
+        {
+            ApiHelper.Response.Content.ReadAsStringAsync().Result.Should().ContainAll("type", "title", "status", "traceId");
             ApiHelper.Response.Content.ReadAsStringAsync().Result.Should().Contain(message);
         }
     }

diff --git a/tests/UnitTests/WorkflowManager.Tests/Controllers/WorkflowsControllerTests.cs b/tests/UnitTests/WorkflowManager.Tests/Controllers/WorkflowsControllerTests.cs
@@ -237,7 +237,7 @@ public async Task UpdateAsync_WorkflowsDoesNotExist_ReturnsNotFound()
 
             var result = await WorkflowsController.UpdateAsync(newWorkflow, workflowRevision.WorkflowId);
 
-            var objectResult = Assert.IsType<NotFoundObjectResult>(result);
+            var objectResult = Assert.IsType<ObjectResult>(result);
 
             Assert.Equal(404, objectResult.StatusCode);
         }