fix not found workflow response #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs integration tests |
Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com>
jackschofield23
force-pushed
the
jschofield/fix-not-found-response
branch
from
1bbda3e
to
1cade95
Compare
… content Signed-off-by: RemakingEden <joss.sparkes@gmail.com>
|
Kudos, SonarCloud Quality Gate passed! |
jackschofield23
added a commit
that referenced
this pull request
Sep 22, 2022
* fix not found workflow response Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com> * fix test Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com> * Changed error assertion to look for basic layout of errors as well as content Signed-off-by: RemakingEden <joss.sparkes@gmail.com> Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com> Signed-off-by: RemakingEden <joss.sparkes@gmail.com> Co-authored-by: RemakingEden <joss.sparkes@gmail.com> Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jack Schofield jack.schofield@answerdigital.com
Description
Fixes #434
makes the not found response a problem details object
Status
Ready
Types of changes