Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed a test to data driven #316

Merged
merged 1 commit into from
Aug 11, 2022
Merged

Changed a test to data driven #316

merged 1 commit into from
Aug 11, 2022

Conversation

RemakingEden
Copy link
Member

Signed-off-by: Joss Sparkes joss.sparkes@gmail.com

Description

A previous test was not data driven that could have been. I have rectified this.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • All tests passed locally.

@RemakingEden
Made a test into data driven for brevity
5a1b594 
Signed-off-by: Joss Sparkes <joss.sparkes@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Aug 11, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@RemakingEden RemakingEden merged commit a0e05bc into develop Aug 11, 2022
@RemakingEden RemakingEden deleted the jsparkes/make-test-data-driven branch August 11, 2022 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackschofield23 jackschofield23 jackschofield23 approved these changes

@lillie-dae lillie-dae Awaiting requested review from lillie-dae

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RemakingEden @jackschofield23