Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration tests for disable pagination and triggered workflow instances #417

Merged

Conversation

RemakingEden
Copy link
Member

@RemakingEden RemakingEden commented Sep 12, 2022

Description

We missed the integration tests for this feature, this will add them. Some more dev work needs doing as initially these tests are failing when using both queries together

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • New tests added to cover the changes.
  • All tests passed locally.

Signed-off-by: RemakingEden <joss.sparkes@gmail.com>
…gered workflows. Test failing for more dev work

Signed-off-by: RemakingEden <joss.sparkes@gmail.com>
@codecov
Copy link

codecov bot commented Sep 12, 2022

Codecov Report

Merging #417 (f455887) into develop (4d9558a) will decrease coverage by 0.05540%.
The diff coverage is 11.11111%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             develop        #417         +/-   ##
===================================================
- Coverage   58.93424%   58.87884%   -0.05541%     
===================================================
  Files            135         135                 
  Lines          16683       16697         +14     
  Branches        1730        1732          +2     
===================================================
- Hits            9832        9831          -1     
- Misses          6544        6559         +15     
  Partials         307         307                 
Flag Coverage Δ
unittests 58.87884% <11.11111%> (-0.05541%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...Manager/Common/Services/WorkflowInstanceService.cs 0.00000% <0.00000%> (ø)
...lowManager/Database/Repositories/RepositoryBase.cs 0.00000% <0.00000%> (ø)
...atabase/Repositories/WorkflowInstanceRepository.cs 0.00000% <0.00000%> (ø)
...wManager/Controllers/WorkflowInstanceController.cs 80.43478% <100.00000%> (ø)
...sts/Controllers/WorkflowInstanceControllerTests.cs 100.00000% <100.00000%> (ø)
...vices/DataRetentionService/DataRetentionService.cs 91.17647% <0.00000%> (-2.94119%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d9558a...f455887. Read the comment docs.

RemakingEden and others added 4 commits September 12, 2022 11:18
…nstances

Signed-off-by: RemakingEden <joss.sparkes@gmail.com>
Signed-off-by: RemakingEden <joss.sparkes@gmail.com>
Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com>
Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com>
Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com>
@jackschofield23 jackschofield23 marked this pull request as ready for review September 12, 2022 13:45
jackschofield23 and others added 4 commits September 12, 2022 15:04
Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com>
Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com>
Signed-off-by: RemakingEden <joss.sparkes@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Sep 13, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

4.3% 4.3% Coverage
0.0% 0.0% Duplication

@neildsouth neildsouth merged commit 6642896 into develop Sep 13, 2022
@RemakingEden RemakingEden deleted the jsparkes/AC555-int-tests-for-triggered-workflow-endpoint branch September 13, 2022 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants