Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent multiple artifacts being added to the output array with duplicated names #457

Merged
merged 6 commits into from
Sep 27, 2022

Conversation

samrooke
Copy link
Collaborator

Description

Prevent multiple artifacts being added to the output array with duplicated names

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • New tests added to cover the changes.
  • All tests passed locally.

Copy link
Member

@RemakingEden RemakingEden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just needs code coverage, LGTM

samrooke and others added 5 commits September 27, 2022 12:27
Signed-off-by: Sam Rooke <sam.rooke@answerdigital.com>
Signed-off-by: RemakingEden <joss.sparkes@gmail.com>
Signed-off-by: Sam Rooke <sam.rooke@answerdigital.com>
Signed-off-by: Sam Rooke <sam.rooke@answerdigital.com>
Signed-off-by: RemakingEden <joss.sparkes@gmail.com>
Signed-off-by: Sam Rooke <sam.rooke@answerdigital.com>
Signed-off-by: Sam Rooke <sam.rooke@answerdigital.com>
@sonarcloud
Copy link

sonarcloud bot commented Sep 27, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

93.3% 93.3% Coverage
0.0% 0.0% Duplication

@samrooke samrooke merged commit 80d1bc4 into develop Sep 27, 2022
@mocsharp mocsharp deleted the AC-582 branch June 11, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants