Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Table service does not conform to v5 API TooBig error code for config limits #2100

Closed
daniel-j-h opened this issue Mar 16, 2016 · 1 comment
Closed

Table service does not conform to v5 API TooBig error code for config limits #2100

daniel-j-h opened this issue Mar 16, 2016 · 1 comment
Labels
Bug Report
Milestone
OSRM 5.0

Comments

@daniel-j-h
Copy link
Member

Per the v5 API spec config limit violations return code TooBig:
https://github.com/Project-OSRM/osrm-backend/wiki/New-Server-api

Table is the only service not returning TooBig in this case:
https://github.com/Project-OSRM/osrm-backend/blob/rewrite/new-api/src/engine/plugins/table.cpp#L52
@daniel-j-h daniel-j-h added this to the OSRM 5.0 milestone Mar 16, 2016
@daniel-j-h daniel-j-h changed the title Table service does not conform to v5 API spec Table service does not conform to v5 API TooBig error code for config limits Mar 16, 2016
daniel-j-h added a commit that referenced this issue Mar 16, 2016
@daniel-j-h
Tests for config level constraints; table failing: see #2100
26b27bf
@daniel-j-h daniel-j-h mentioned this issue Mar 16, 2016
Merged
17 tasks
daniel-j-h added a commit that referenced this issue Mar 17, 2016
@daniel-j-h
Tests for config level constraints; table failing: see #2100
021b971
daniel-j-h added a commit that referenced this issue Mar 17, 2016
@daniel-j-h
Makes table plugin adhere to v5 spec for limit violations, fixes #2100
898049a
TheMarex pushed a commit that referenced this issue Mar 18, 2016
@daniel-j-h @TheMarex
Tests for config level constraints; table failing: see #2100
10f3cc0
TheMarex pushed a commit that referenced this issue Mar 18, 2016
@daniel-j-h @TheMarex
Makes table plugin adhere to v5 spec for limit violations, fixes #2100
ed83eb9
daniel-j-h added a commit that referenced this issue Mar 22, 2016
@daniel-j-h
Tests for config level constraints; table failing: see #2100
f5ccf3e
daniel-j-h added a commit that referenced this issue Mar 22, 2016
@daniel-j-h
Makes table plugin adhere to v5 spec for limit violations, fixes #2100
c49e2a0
daniel-j-h added a commit that referenced this issue Mar 23, 2016
@daniel-j-h
Tests for config level constraints; table failing: see #2100
b8524b9
daniel-j-h added a commit that referenced this issue Mar 23, 2016
@daniel-j-h
Makes table plugin adhere to v5 spec for limit violations, fixes #2100
87ee3cc
daniel-j-h added a commit that referenced this issue Mar 23, 2016
@daniel-j-h
Tests for config level constraints; table failing: see #2100
e0e18d6
daniel-j-h added a commit that referenced this issue Mar 23, 2016
@daniel-j-h
Makes table plugin adhere to v5 spec for limit violations, fixes #2100
728d72d
TheMarex pushed a commit that referenced this issue Mar 23, 2016
@daniel-j-h @TheMarex
Tests for config level constraints; table failing: see #2100
34d8ca5
TheMarex pushed a commit that referenced this issue Mar 23, 2016
@daniel-j-h @TheMarex
Makes table plugin adhere to v5 spec for limit violations, fixes #2100
9881699
TheMarex pushed a commit that referenced this issue Mar 23, 2016
@daniel-j-h @TheMarex
Tests for config level constraints; table failing: see #2100
b0d13a6
TheMarex pushed a commit that referenced this issue Mar 23, 2016
@daniel-j-h @TheMarex
Makes table plugin adhere to v5 spec for limit violations, fixes #2100
981a1dd
TheMarex pushed a commit that referenced this issue Mar 24, 2016
@daniel-j-h @TheMarex
Tests for config level constraints; table failing: see #2100
70d4213
TheMarex pushed a commit that referenced this issue Mar 24, 2016
@daniel-j-h @TheMarex
Makes table plugin adhere to v5 spec for limit violations, fixes #2100
142cd52
@TheMarex
Copy link
Member

This landed. 🎉

TheMarex pushed a commit that referenced this issue Mar 25, 2016
@daniel-j-h @TheMarex
Tests for config level constraints; table failing: see #2100
414dc10
TheMarex pushed a commit that referenced this issue Mar 25, 2016
@daniel-j-h @TheMarex
Makes table plugin adhere to v5 spec for limit violations, fixes #2100
a31a033
lbud pushed a commit that referenced this issue Mar 25, 2016
@daniel-j-h
Tests for config level constraints; table failing: see #2100
3c61423
lbud pushed a commit that referenced this issue Mar 25, 2016
@daniel-j-h
Makes table plugin adhere to v5 spec for limit violations, fixes #2100
7eb136a
TheMarex pushed a commit that referenced this issue Mar 31, 2016
@daniel-j-h @TheMarex
Tests for config level constraints; table failing: see #2100
fea6c27
TheMarex pushed a commit that referenced this issue Mar 31, 2016
@daniel-j-h @TheMarex
Makes table plugin adhere to v5 spec for limit violations, fixes #2100
cb212a7
TheMarex pushed a commit that referenced this issue Apr 5, 2016
@daniel-j-h @TheMarex
Tests for config level constraints; table failing: see #2100
c22453f
TheMarex pushed a commit that referenced this issue Apr 5, 2016
@daniel-j-h @TheMarex
Makes table plugin adhere to v5 spec for limit violations, fixes #2100
224c66e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Report
Projects
None yet
Milestone
OSRM 5.0
Development

No branches or pull requests
2 participants
@daniel-j-h @TheMarex