Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Geometry points being dropped when map-matching using waypoints parameter #4909

Closed
danpat opened this issue Feb 23, 2018 · 1 comment
Closed

Geometry points being dropped when map-matching using waypoints parameter #4909

danpat opened this issue Feb 23, 2018 · 1 comment
Assignees
@karenzshea

Comments

@danpat
Copy link
Member

danpat commented Feb 23, 2018

The following test case fails, but it should pass:

    Scenario: Regression test - waypoints trimming too much geometry
        Given the node map
            """
            ad
            |
            |
            |
            |
            |e   g
            b--------------c
            f              h
            """

        And the ways
            | nodes |
            | ab    |
            | bc    |

        Given the query options
            | waypoints | 0;4   |

        When I match I should get
            | trace    | geometry                                                     | code |
            | defgh    | 1,1,1,0.99955,1,0.999461,1.000225,0.999461,1.000674,0.999461 | Ok   |

Disabling the waypoints query option on this test will cause it to pass.

/cc @karenzshea
@karenzshea karenzshea self-assigned this Feb 23, 2018
@karenzshea karenzshea mentioned this issue Feb 23, 2018
Merged
5 tasks
@danpat
Copy link
Member Author

danpat commented Feb 24, 2018

Fixed by #4911, thanks @karenzshea !

@danpat danpat closed this as completed Feb 24, 2018
uqs pushed a commit to freebsd/freebsd-ports that referenced this issue Feb 24, 2018
www/osrm-backend: Update to 5.15.3
3a74b83 
Changes from 5.15.2:
- Bugfixes: fix deduplication of route steps when waypoints are used [#4909]
  Project-OSRM/osrm-backend#4909

Additional port changes:
* Removed USE_LDCONFIG (no shared libs)
* Grouped USExx
* Silenced the pre-install command

PR:		226156
Submitted by:	Andreas Andersson <a.andersson.thn@gmail.com> (maintainer)
Approved by:	tcberner (mentor, implicit)


git-svn-id: svn+ssh://svn.freebsd.org/ports/head@462853 35697150-7ecd-e111-bb59-0022644237b5
uqs pushed a commit to freebsd/freebsd-ports that referenced this issue Feb 24, 2018
@yurivict
www/osrm-backend: Update to 5.15.3
5504af7 
Changes from 5.15.2:
- Bugfixes: fix deduplication of route steps when waypoints are used [#4909]
  Project-OSRM/osrm-backend#4909

Additional port changes:
* Removed USE_LDCONFIG (no shared libs)
* Grouped USExx
* Silenced the pre-install command

PR:		226156
Submitted by:	Andreas Andersson <a.andersson.thn@gmail.com> (maintainer)
Approved by:	tcberner (mentor, implicit)
swills pushed a commit to swills/freebsd-ports that referenced this issue Feb 24, 2018
@yurivict
www/osrm-backend: Update to 5.15.3
812d80d 
Changes from 5.15.2:
- Bugfixes: fix deduplication of route steps when waypoints are used [#4909]
  Project-OSRM/osrm-backend#4909

Additional port changes:
* Removed USE_LDCONFIG (no shared libs)
* Grouped USExx
* Silenced the pre-install command

PR:		226156
Submitted by:	Andreas Andersson <a.andersson.thn@gmail.com> (maintainer)
Approved by:	tcberner (mentor, implicit)


git-svn-id: svn+ssh://svn.freebsd.org/ports/head@462853 35697150-7ecd-e111-bb59-0022644237b5
Jehops pushed a commit to Jehops/freebsd-ports-legacy that referenced this issue Feb 24, 2018
@yurivict
www/osrm-backend: Update to 5.15.3
cddafef 
Changes from 5.15.2:
- Bugfixes: fix deduplication of route steps when waypoints are used [#4909]
  Project-OSRM/osrm-backend#4909

Additional port changes:
* Removed USE_LDCONFIG (no shared libs)
* Grouped USExx
* Silenced the pre-install command

PR:		226156
Submitted by:	Andreas Andersson <a.andersson.thn@gmail.com> (maintainer)
Approved by:	tcberner (mentor, implicit)


git-svn-id: svn+ssh://svn.freebsd.org/ports/head@462853 35697150-7ecd-e111-bb59-0022644237b5
svmhdvn pushed a commit to svmhdvn/freebsd-ports that referenced this issue Jan 10, 2024
@yurivict
www/osrm-backend: Update to 5.15.3
723d25a 
Changes from 5.15.2:
- Bugfixes: fix deduplication of route steps when waypoints are used [#4909]
  Project-OSRM/osrm-backend#4909

Additional port changes:
* Removed USE_LDCONFIG (no shared libs)
* Grouped USExx
* Silenced the pre-install command

PR:		226156
Submitted by:	Andreas Andersson <a.andersson.thn@gmail.com> (maintainer)
Approved by:	tcberner (mentor, implicit)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@karenzshea karenzshea

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danpat @karenzshea