Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle empty server.ini #692

Closed
springmeyer opened this issue Aug 7, 2013 · 1 comment
Closed

handle empty server.ini #692

springmeyer opened this issue Aug 7, 2013 · 1 comment

Comments

@springmeyer
Copy link
Contributor

It appears that trying to read a server.ini that is blank will lead to high memory (> 5 GB) inf recursion. Seen on OS X via node-osrm (when trying to write tests for error states):

screen shot 2013-08-07 at 1 22 00 pm
springmeyer pushed a commit to Project-OSRM/node-osrm that referenced this issue Aug 7, 2013
a bunch more tests for failure states + some disabled due to Project-…
6e832b4 
…OSRM/osrm-backend#693 and Project-OSRM/osrm-backend#692
@springmeyer springmeyer mentioned this issue Aug 8, 2013
Closed
@DennisOSRM
Copy link
Collaborator

I got this implemented now and it checks for all files in server.ini:

$ ./osrm-routed empty.ini 
[warn] starting up engines, compiled at Aug  9 2013, 14:37:00
[fatal error] exception: no ram index file name in server ini

Running some tests now that nothing breaks and will push shortly afterwards.

DennisOSRM pushed a commit that referenced this issue Aug 9, 2013
Implements #692
0765ebf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@springmeyer @DennisOSRM