Port OSRM Text Instructions to v0.5.0

[1ec5]

This PR gets the Swift library back in sync with the JavaScript library, upgrading it from v0.2.1 to Project-OSRM/osrm-text-instructions@020e28b, which is equivalent to v0.4.0 plus Project-OSRM/osrm-text-instructions#116 and some translation updates. To wit, this PR makes the following changes:

• Updates translations, bringing in:
  • A new Indonesian localization (Add Indonesian localization from Transifex osrm-text-instructions#104)
  • A new Polish localization (Polish translation osrm-text-instructions#120)
  • Updates to the German localization (Update German translation osrm-text-instructions#122)
  • Updates to the Vietnamese localization (Viexit osrm-text-instructions#123)
• When there are multiple legs in the route, an intermediate waypoint’s arrival instruction correctly identifies the waypoint by its ordinal (fixes Count waypoint upon arrival #24)
  • Added optional arguments to OSRMInstructionFormatter.string(for:modifyValueByKey:) to track which leg the instruction is on.
  • Fixed the raw value of TokenType.wayPoint.
• An instruction to take an off-ramp indicates the exit number where available (fixes Include exit number in off-ramp instructions #25)
  • Added TokenType.exitCode.
  • Renamed TokenType.exit to exitIndex for clarity.
• The unit tests force the ordinal formatter to use the fixture language (English) rather than the test machine’s language, allowing the tests to finally pass on my machine 🎉
• Revert Cartfile to point to a MapboxDirections.swift release again, once Expose exit numbers on route steps mapbox/mapbox-directions-swift#147 lands

(Project-OSRM/osrm-text-instructions#107 is irrelevant to this library because Bundle handles language fallbacks in Swift.)

Depends on mapbox/mapbox-directions-swift#147, which is on hold until the exits property lands in the production Directions API.

/cc @bsudekum @freenerd @willwhite

[freenerd]

why not stick with the js names exit and exitNumber?

[1ec5]

Same reasoning as in mapbox/mapbox-directions-swift#147, where exitCodes is for what’s colloquially called an exit number (exitIdentifiers being another candidate) and exitIndex remains the count of exits from the beginning of the step. I figured consistency with MapboxDirections.swift would be more important for Swift developers than consistency with the JavaScript library they’ll never use. But if you think it’s more important to keep the libraries consistent with each other (to make merging more straightforward?), I can change them to exit and exitNumber here.

[1ec5]

Per discussion with @bsudekum, I’m going to merge this and get a release out in order to unblock a navigation SDK release. However, if you think we should change the enumeration values back to match the JavaScript version, please open a ticket and we can address it in a subsequent release. (We’re pre-1.0, so we don’t have to worry much about backwards compatibility.)