Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osrm-text-instructions v0.7.0 #38

Merged
merged 5 commits into from
Sep 15, 2017
Merged

Conversation

1ec5
Copy link
Member

@1ec5 1ec5 commented Sep 14, 2017

Upgraded to MapboxDirections.swift v0.10.4 and OSRM Text Instructions v0.7.0.

Added some cases for phrase-specific tokens to TokenType. Extracted token replacement code for a String extension method. Added tests for token substitution in phrases. Simplified test code.

Fixes #37.

/cc @bsudekum @mcwhittemore

@1ec5 1ec5 self-assigned this Sep 14, 2017
@1ec5 1ec5 requested a review from bsudekum September 14, 2017 09:52
Added some cases for phrase tokens to TokenType. Extracted token replacement code for a String extension method. Added tests for token substitution in phrases. Simplified test code.
@1ec5 1ec5 force-pushed the 1ec5-osrm-text-instructions-v0.6.0 branch from 7d04105 to 1d999b5 Compare September 14, 2017 10:39
@1ec5 1ec5 changed the title osrm-text-instructions v0.6.0 osrm-text-instructions v0.7.0 Sep 14, 2017
@1ec5 1ec5 mentioned this pull request Sep 14, 2017
Copy link

@bsudekum bsudekum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!

@1ec5 1ec5 merged commit b48a5a0 into master Sep 15, 2017
@1ec5 1ec5 deleted the 1ec5-osrm-text-instructions-v0.6.0 branch September 15, 2017 04:49
@1ec5 1ec5 mentioned this pull request Sep 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants