No way_name/destination with use lane #38
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm a bit unclear how
type: use lane
will actually be used.It feels to me that
name
anddestination
only make sense, if they actually distinguish the lanes from each other. Since all lanes are on the same OSM way though, all lanes would have the samename/destination
information. Thus we should not include that information in the text instruction, since it will be the same for all lanes.We could re-introduce
destination
instructions if OSRM would support thedestination:lanes
OSM tag, ticketed here Project-OSRM/osrm-backend#2553 (comment) already/cc @MoKob @daniel-j-h @bsudekum