Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No way_name/destination with use lane #38

Merged
merged 1 commit into from
Oct 19, 2016
Merged

No way_name/destination with use lane #38

merged 1 commit into from
Oct 19, 2016

Conversation

freenerd
Copy link
Member

I'm a bit unclear how type: use lane will actually be used.

It feels to me that name and destination only make sense, if they actually distinguish the lanes from each other. Since all lanes are on the same OSM way though, all lanes would have the same name/destination information. Thus we should not include that information in the text instruction, since it will be the same for all lanes.

We could re-introduce destination instructions if OSRM would support the destination:lanes OSM tag, ticketed here Project-OSRM/osrm-backend#2553 (comment) already

/cc @MoKob @daniel-j-h @bsudekum

@daniel-j-h
Copy link
Member

UseLane will be emitted e.g. in Lane Anticipation: take this file as an example (search for "use lane").

Where you could take multiple lanes going straight but we constraint it to specific lanes, you'll get a UseLane with constraint lane data in the response.

This has no influence on the destination value, since a destination tag without lane namespace applies to the overall way and not to specific lanes.

The only way to find out: sample OSM for destination tags right in front of turns that have lanes attached.

@freenerd
Copy link
Member Author

The only way to find out: sample OSM for destination tags right in front of turns that have lanes attached.

This is out-of-scope for osrm-text-instructions. Should I add that as a new issue on osrm-backend?

@daniel-j-h I take from your comment that the implementation in this PR makes sense?

@daniel-j-h
Copy link
Member

I looked deeper into this, turns out there is a problem in OSRM during collapsing: the way we collapse steps could result in us emitting destination signs for (collapsed) steps later.

Ticketed in Project-OSRM/osrm-backend#3097.

@freenerd
Copy link
Member Author

Merging this and will fix #42 later

@freenerd freenerd merged commit 0702a53 into master Oct 19, 2016
@freenerd freenerd deleted the use-lane-no-name branch October 19, 2016 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants