Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fix php #504

Merged
merged 2 commits into from
Sep 27, 2018
Merged

Small fix php #504

merged 2 commits into from
Sep 27, 2018

Conversation

adanielvv
Copy link
Contributor

Is needed to suppress Warning: Use of undefined constant yes - assumed 'yes' (this will throw an Error in a future version of PHP)

Is needed to suppress Warning: Use of undefined constant yes - assumed 'yes' (this will throw an Error in a future version of PHP)
@bjendres
Copy link
Member

Hi @adanielvv. Well spotted!

However, the $can_delete variable is definitely a boolean, so shouldn't we rather replace

{if $can_delete eq yes}

with:

{if $can_delete}

Doesn't that make more sense? Did you test your fix?

@bjendres bjendres added this to the 1.3 milestone Sep 27, 2018
@adanielvv
Copy link
Contributor Author

Yes, that is better. I just tested it.
{if $can_delete eq yes} is equivalent to:

  • {if $can_delete eq "yes"}
  • {if $can_delete eq "thisissomething"}
  • {if $can_delete}

@bjendres bjendres merged commit d0c4bce into Project60:master Sep 27, 2018
@bjendres
Copy link
Member

Great, thanks @adanielvv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants