Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GraphQL (Apollo) data as its own package #278

Closed
1 of 5 tasks
thescientist13 opened this issue Jan 17, 2020 · 2 comments · Fixed by #487 or #490
Closed
1 of 5 tasks

GraphQL (Apollo) data as its own package #278

thescientist13 opened this issue Jan 17, 2020 · 2 comments · Fixed by #487 or #490
Assignees
@thescientist13 @hutchgrant
Labels
alpha.8 CLI Data Data and GraphQL P0 Critical issue that should get addressed ASAP v0.10.0
Projects
4 - Data Sources 5 - Architectural Digest
Milestone
No Bundle Feature...

Comments

@thescientist13
Copy link
Member

thescientist13 commented Jan 17, 2020 •
edited
Loading

Type of Change

  • New Feature Request
  • Documentation / Website
  • Improvement / Suggestion
  • Bug
  • Other (please clarify below)

Summary

Should @greenwood/cli/data, e,g. package/cli/data be it's own distinct package?

Details

There's also the case that it can be its own package (to maintain its own test cases, dependencies, etc) but have it be a direct dependency of @greenwood/cli. Essentially they would be functionally coupled, but benefit by having code logically organized.

Also, for now, we can just alias it as @greenwood/data and that way, if it becomes a package or not, it won't break user land code since the import path will stay the same.
@thescientist13 thescientist13 added question Further information is requested Data Data and GraphQL labels Jan 17, 2020
@thescientist13 thescientist13 added this to the MVP milestone Jan 17, 2020
@thescientist13 thescientist13 mentioned this issue Jan 17, 2020
Merged
21 tasks
@thescientist13 thescientist13 added this to IN PROGRESS in 4 - Data Sources Jan 17, 2020
@thescientist13 thescientist13 changed the title should data be its own package? should data be its own package / navigation? Jan 24, 2020
@thescientist13 thescientist13 mentioned this issue Jan 29, 2020
Merged
13 tasks
@thescientist13 thescientist13 mentioned this issue Apr 11, 2020
Closed
5 tasks
@thescientist13 thescientist13 moved this from IN PROGRESS to TODO in 4 - Data Sources Apr 29, 2020
@thescientist13 thescientist13 moved this from TODO to IN PROGRESS in 4 - Data Sources Apr 29, 2020
@thescientist13 thescientist13 mentioned this issue Sep 22, 2020
Closed
53 tasks
@thescientist13
Copy link
Member Author

I think coming out of #355 this will happen organically.

@thescientist13 thescientist13 moved this from TODO to INVALID in 5 - Architectural Digest Nov 7, 2020
@thescientist13 thescientist13 changed the title should data be its own package / navigation? data should be its own package (?) Nov 7, 2020
@thescientist13
Copy link
Member Author

Re-purposing to help solve #418

  1. Make data a plugin and something lighter than apollo?
  2. update all usages to use @data/client instead of fetch in www/
  3. See if data hydration still an issue
  4. reduce duplicate graphql calls?

@thescientist13 thescientist13 changed the title data should be its own package (?) GraphQL (Apollo) data should be its own package (?) Nov 8, 2020
@thescientist13 thescientist13 added the P0 Critical issue that should get addressed ASAP label Nov 8, 2020
@thescientist13 thescientist13 moved this from INVALID to TODO in 5 - Architectural Digest Nov 8, 2020
@thescientist13 thescientist13 removed the question Further information is requested label Nov 8, 2020
@thescientist13 thescientist13 changed the title GraphQL (Apollo) data should be its own package (?) GraphQL (Apollo) data as its own package Nov 8, 2020
@thescientist13 thescientist13 mentioned this issue Nov 12, 2020
Merged
12 tasks
This was referenced Dec 18, 2020
Merged
Merged
@thescientist13 thescientist13 linked a pull request Feb 3, 2021 that will close this issue
Server Plugin API #471
Merged
@thescientist13 thescientist13 removed a link to a pull request Feb 14, 2021
Server Plugin API #471
Merged
@thescientist13 thescientist13 self-assigned this Mar 7, 2021
@thescientist13 thescientist13 moved this from TODO to IN PROGRESS in 5 - Architectural Digest Mar 7, 2021
@thescientist13 thescientist13 mentioned this issue Mar 8, 2021
Merged
6 tasks
@thescientist13 thescientist13 linked a pull request Mar 8, 2021 that will close this issue
Enhancement/issue 278 graphql plugin #487
Merged
6 tasks
@thescientist13 thescientist13 moved this from IN PROGRESS to IN REVIEW in 5 - Architectural Digest Mar 14, 2021
@thescientist13 thescientist13 moved this from IN REVIEW to DONE in 5 - Architectural Digest Mar 19, 2021
@thescientist13 thescientist13 mentioned this issue Mar 19, 2021
Merged
@thescientist13 thescientist13 linked a pull request Mar 19, 2021 that will close this issue
removed some text that accidentally got into the Data docs #490
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thescientist13 thescientist13

@hutchgrant hutchgrant

Labels
alpha.8 CLI Data Data and GraphQL P0 Critical issue that should get addressed ASAP v0.10.0
Projects
No open projects
4 - Data Sources
IN PROGRESS
5 - Architectural Digest
DONE
Milestone
No Bundle Feature Parity
3 participants
@thescientist13 @hutchgrant @aholtzman