release/0.5.0 #284

thescientist13 · 2020-01-29T02:43:51Z

Related Issue

The minimum needed atomic changeset to deliver / release the initial Data Sources work

[RFC] Build Time Data Injection #115

As this is a release branch, the following branch maintenance should be followed

PRs into this branch should be squashed merged
Rebase this branch when all work is done
Merge (NO squash) into master when ready

Summary of Changes

[RFC] Build Time Data Access - [RFC] Build Time Data Injection #115
Deterministic Queries - query results are not deterministic #271
Configuration as data - expose Greenwood configuration as data #270
<title> from data - <title></title> element is static #128
<meta> from data - improve unit test coverage for the meta plugin (get meta from data) #125
fixed gql-loader not working - gql loader not resolving and breaking the CLI #311
Custom frontmatter as data - support passing front matter from pages to graph (custom content metadata in markdown) #274
NavigationQuery -> MenuQuery / side nav refactor - refactor navigation and shelf into single query #291
Temporary fix for handling routes with and without / - Bug/issue 128 fix undefined link title setting #308 / routes with and without trailing forward slash causes route "misses" #331
Documentation syntax fix - show correct syntax in custom frontmatter docs #334
Clean up TODOs and console logs - remove TODO comments, console.logs #336

Breaking Changes

Remove references to METAIMPORT, METADATA, METAELEMENT from xxx-template.js

TODO

Nice To Have

articulate vision articulate Greenwood's vision / value through the home page #268 - maybe save for Architectural Digest sprint?
~~graph resolvers assume a fixed depth for root~~ - resolvers and file writing assumes certain route depth #273 (can be post release)
~~[RFC] Code Splitting * (nice to have)~~ - [RFC] Route Based Code Splitting #136 (moved to Project 5)

Questions / Thoughts

N / A

* graphql server working * apollo client connect to apollo server * connected header example using lit apollo * todo * todos * query and client + server refactor * schema refactoring * clean up console logging * alias all @greenwood/cli/data module imports * avoid paramater destructuring * graphql example in the header * multiple schemas * internal data sources documentation * shelf refactor and children query integration * refactor out ApolloQuery * ability to intercept client.query calls * basic semi-working implementation * remove extra config from server context * have puppeteer wait for graphql requests before returning content * fix and add test cases for apollo * merged resolvers not actually working * multiple queries support * everything working * todos * TODO tracking * fix fallback apollo client fetch handling * full test suite * cache json test cases * stablize test due to inconsistent data results ordering * clean up deps * todo cleanup * remove forced client call in SSG mode for client * represent graph through the schema * updated data docs * typos and grammer * typos and community link fixes

* Rfc/issue 115 build time data access (#269) * graphql server working * apollo client connect to apollo server * connected header example using lit apollo * todo * todos * query and client + server refactor * schema refactoring * clean up console logging * alias all @greenwood/cli/data module imports * avoid paramater destructuring * graphql example in the header * multiple schemas * internal data sources documentation * shelf refactor and children query integration * refactor out ApolloQuery * ability to intercept client.query calls * basic semi-working implementation * remove extra config from server context * have puppeteer wait for graphql requests before returning content * fix and add test cases for apollo * merged resolvers not actually working * multiple queries support * everything working * todos * TODO tracking * fix fallback apollo client fetch handling * full test suite * cache json test cases * stablize test due to inconsistent data results ordering * clean up deps * todo cleanup * remove forced client call in SSG mode for client * represent graph through the schema * updated data docs * typos and grammer * typos and community link fixes * unit test data graph * linting * lint fix * added ordered index tracking when serializing pages * formatting * document graph page ordering * cli data graph unit tests and expand mocha spec globbing * address missing hash in mock graph * loosen graph test case asserts * update graph tests to focus less on implementation details * add back missing develop task

* Rfc/issue 115 build time data access (#269) * graphql server working * apollo client connect to apollo server * connected header example using lit apollo * todo * todos * query and client + server refactor * schema refactoring * clean up console logging * alias all @greenwood/cli/data module imports * avoid paramater destructuring * graphql example in the header * multiple schemas * internal data sources documentation * shelf refactor and children query integration * refactor out ApolloQuery * ability to intercept client.query calls * basic semi-working implementation * remove extra config from server context * have puppeteer wait for graphql requests before returning content * fix and add test cases for apollo * merged resolvers not actually working * multiple queries support * everything working * todos * TODO tracking * fix fallback apollo client fetch handling * full test suite * cache json test cases * stablize test due to inconsistent data results ordering * clean up deps * todo cleanup * remove forced client call in SSG mode for client * represent graph through the schema * updated data docs * typos and grammer * typos and community link fixes * hello and graph queries working together * config def and resolvers * use real config data * flesh out config schema and query * remove theme file from config * delete hello query example * config unit tests * rename mock graph * formatting * documentation

* Rfc/issue 115 build time data access (#269) * graphql server working * apollo client connect to apollo server * connected header example using lit apollo * todo * todos * query and client + server refactor * schema refactoring * clean up console logging * alias all @greenwood/cli/data module imports * avoid paramater destructuring * graphql example in the header * multiple schemas * internal data sources documentation * shelf refactor and children query integration * refactor out ApolloQuery * ability to intercept client.query calls * basic semi-working implementation * remove extra config from server context * have puppeteer wait for graphql requests before returning content * fix and add test cases for apollo * merged resolvers not actually working * multiple queries support * everything working * todos * TODO tracking * fix fallback apollo client fetch handling * full test suite * cache json test cases * stablize test due to inconsistent data results ordering * clean up deps * todo cleanup * remove forced client call in SSG mode for client * represent graph through the schema * updated data docs * typos and grammer * typos and community link fixes * fix cache.json lookup for deep linking * clean up from rebase * clean up from rebase

* Rfc/issue 115 build time data access (#269) * graphql server working * apollo client connect to apollo server * connected header example using lit apollo * todo * todos * query and client + server refactor * schema refactoring * clean up console logging * alias all @greenwood/cli/data module imports * avoid paramater destructuring * graphql example in the header * multiple schemas * internal data sources documentation * shelf refactor and children query integration * refactor out ApolloQuery * ability to intercept client.query calls * basic semi-working implementation * remove extra config from server context * have puppeteer wait for graphql requests before returning content * fix and add test cases for apollo * merged resolvers not actually working * multiple queries support * everything working * todos * TODO tracking * fix fallback apollo client fetch handling * full test suite * cache json test cases * stablize test due to inconsistent data results ordering * clean up deps * todo cleanup * remove forced client call in SSG mode for client * represent graph through the schema * updated data docs * typos and grammer * typos and community link fixes * hello and graph queries working together * config def and resolvers * flesh out config schema and query * remove theme file from config * delete hello query example * formatting * documentation * app template with config title from data * page title with project title * tests for custom page title * cleanup console log * docs

* Rfc/issue 115 build time data access (#269) * graphql server working * apollo client connect to apollo server * connected header example using lit apollo * todo * todos * query and client + server refactor * schema refactoring * clean up console logging * alias all @greenwood/cli/data module imports * avoid paramater destructuring * graphql example in the header * multiple schemas * internal data sources documentation * shelf refactor and children query integration * refactor out ApolloQuery * ability to intercept client.query calls * basic semi-working implementation * remove extra config from server context * have puppeteer wait for graphql requests before returning content * fix and add test cases for apollo * merged resolvers not actually working * multiple queries support * everything working * todos * TODO tracking * fix fallback apollo client fetch handling * full test suite * cache json test cases * stablize test due to inconsistent data results ordering * clean up deps * todo cleanup * remove forced client call in SSG mode for client * represent graph through the schema * updated data docs * typos and grammer * typos and community link fixes * hello and graph queries working together * config def and resolvers * flesh out config schema and query * remove theme file from config * delete hello query example * formatting * documentation * app template with config title from data * tests for custom page title * refactoring meta to app-template and data instead of scaffolding and added tests * update coverage config * fix spelling mistake

* WIP custom frontmatter data to graphql * dynamic data resolvers * dynamic Data def from graph WIP * dynamic data from graph and default handling * prune reserved frontmatter variables * document custom data frontmatter * add testing for multiple front matter variables * unit testing

* Rfc/issue 115 build time data access (#269) * graphql server working * apollo client connect to apollo server * connected header example using lit apollo * todo * todos * query and client + server refactor * schema refactoring * clean up console logging * alias all @greenwood/cli/data module imports * avoid paramater destructuring * graphql example in the header * multiple schemas * internal data sources documentation * shelf refactor and children query integration * refactor out ApolloQuery * ability to intercept client.query calls * basic semi-working implementation * remove extra config from server context * have puppeteer wait for graphql requests before returning content * fix and add test cases for apollo * merged resolvers not actually working * multiple queries support * everything working * todos * TODO tracking * fix fallback apollo client fetch handling * full test suite * cache json test cases * stablize test due to inconsistent data results ordering * clean up deps * todo cleanup * remove forced client call in SSG mode for client * represent graph through the schema * updated data docs * typos and grammer * typos and community link fixes * Bug/issue 271 determinism (#292) * Rfc/issue 115 build time data access (#269) * graphql server working * apollo client connect to apollo server * connected header example using lit apollo * todo * todos * query and client + server refactor * schema refactoring * clean up console logging * alias all @greenwood/cli/data module imports * avoid paramater destructuring * graphql example in the header * multiple schemas * internal data sources documentation * shelf refactor and children query integration * refactor out ApolloQuery * ability to intercept client.query calls * basic semi-working implementation * remove extra config from server context * have puppeteer wait for graphql requests before returning content * fix and add test cases for apollo * merged resolvers not actually working * multiple queries support * everything working * todos * TODO tracking * fix fallback apollo client fetch handling * full test suite * cache json test cases * stablize test due to inconsistent data results ordering * clean up deps * todo cleanup * remove forced client call in SSG mode for client * represent graph through the schema * updated data docs * typos and grammer * typos and community link fixes * unit test data graph * linting * lint fix * added ordered index tracking when serializing pages * formatting * document graph page ordering * cli data graph unit tests and expand mocha spec globbing * address missing hash in mock graph * loosen graph test case asserts * update graph tests to focus less on implementation details * add back missing develop task * task: refactor into single menu query, enable menu filtering with markdown declarations * fix shelf * fix: shelf rendering collapse/expand * test: update al related tests * fix: remove debug * task: basic sorting label/index * fix: index sorting * fix: remove debug * fix: current tests * test: amending tests, removing prev mock * test: revert previous graphql test case * test: remove hello query * fix: remove deprecated .json files * fix: refactor mock graph func * test: adding sort/filter menu tests * task: add documentation for menus * fix: amend documentation * fix: amend docs for route var * fix: typo * task: add headingLevel and route condition, remove hardcoded vars * fix: non-pathname menus may want linkheadings children * task: amend docs for child heading level * fix: change linkheadings to integer, use for headingLevel * docs: remove navigation query docs * test: fix test * task: revert stub generation code * fix: update data sources doc * fix: amend docs for route/linkheadings additions * fix: update filter to use title instead of label * fix: test * task: update docs with linkheadings query result Co-authored-by: Owen Buckley <owenbuckley13@gmail.com>

thescientist13

Going to merge the following items, then merge this into master

* remove TODO comments * remove extra console logs from website code

thescientist13

OK, this is ready for final review. 👀
https://deploy-preview-284--elastic-blackwell-3aef44.netlify.app/

thescientist13 · 2020-04-22T23:11:00Z

packages/cli/package.json

    "html-webpack-plugin": "^3.2.0",
    "lit-element": "^2.0.1",
    "lit-redux-router": "^0.9.3",
    "local-web-server": "^2.6.1",
+    "markdown-toc": "^1.2.0",
+    "node-fetch": "^2.6.0",


would be nice if we could remove the dependency on this. will track in Trello

thescientist13 · 2020-04-22T23:14:45Z

packages/cli/src/data/queries/menu.gql

+        label,
+        link
+      },
+      children {


will this need some logic to scale, or if I am reading this right, this only supports one level of nesting, right? Maybe related to #273

yes, only one nested level

thescientist13 · 2020-04-22T23:15:25Z

packages/cli/src/data/schema/graph.js

+      const { label } = getDeriveMetaFromRoute(route);
+      const id = page.label;
+
+      pages.push({


some duplication here, would probably be good to make an issue for this.

thescientist13 · 2020-04-24T01:26:00Z

As report of the week would say, release/0.5.0 going in.

thescientist13 added RFC Proposal and changes to workflows, architecture, APIs, etc website Tasks related to the projects website / documentation documentation Greenwood specific docs Content as Data labels Jan 29, 2020

thescientist13 assigned thescientist13 and hutchgrant Jan 29, 2020

thescientist13 force-pushed the release/0.5.0 branch from f51b836 to 21ffa99 Compare March 2, 2020 01:22

This was referenced Mar 3, 2020

upgrade to 0.5.0 ProjectEvergreen/greenwood-getting-started#12

Merged

upgrade to latest greenwood 0.5.0 w/ graphql thegreenhouseio/www.thegreenhouse.io#132

Merged

thescientist13 force-pushed the release/0.5.0 branch from a24bcde to 50e42a9 Compare March 11, 2020 01:12

thescientist13 added 2 commits March 15, 2020 18:50

thescientist13 force-pushed the release/0.5.0 branch from 50e42a9 to 8d1529a Compare March 15, 2020 23:00

thescientist13 added the CLI label Mar 15, 2020

thescientist13 added 3 commits March 17, 2020 21:48

thescientist13 mentioned this pull request Mar 27, 2020

gql loader not resolving and breaking the CLI #311

Closed

5 tasks

thescientist13 added 3 commits March 27, 2020 20:58

remove node_modules exclude from graph loader (#312)

491707e

clean up console logging (#307)

b746b81

thescientist13 mentioned this pull request Apr 19, 2020

remove TODO comments, console.logs #336

Merged

thescientist13 requested review from hutchgrant and aholtzman April 22, 2020 22:09

thescientist13 commented Apr 22, 2020

View reviewed changes

thescientist13 added the v0.5.0 Data w/ GraphQL label Apr 22, 2020

thescientist13 changed the title ~~[WIP] release/0.5.0~~ release/0.5.0 Apr 22, 2020

handling page not found case (#308)

ff3f170

thescientist13 added 2 commits April 22, 2020 18:34

use correct syntax (#334)

319b76d

remove TODO comments, console.logs (#336)

d8b9ee1

* remove TODO comments * remove extra console logs from website code

thescientist13 commented Apr 22, 2020

View reviewed changes

thescientist13 added this to the MVP milestone Apr 22, 2020

thescientist13 added this to IN REVIEW in 4 - Data Sources Apr 22, 2020

thescientist13 commented Apr 22, 2020

View reviewed changes

thescientist13 merged commit 3b52417 into master Apr 24, 2020

thescientist13 moved this from IN REVIEW to DONE in 4 - Data Sources Apr 24, 2020

thescientist13 mentioned this pull request May 1, 2020

Route Based Code Splitting #265

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

release/0.5.0 #284

release/0.5.0 #284

thescientist13 commented Jan 29, 2020 •

edited

Loading

thescientist13 left a comment •

edited

Loading

thescientist13 left a comment •

edited

Loading

thescientist13 Apr 22, 2020

thescientist13 Apr 22, 2020

hutchgrant Apr 22, 2020 •

edited

Loading

thescientist13 Apr 22, 2020

thescientist13 commented Apr 24, 2020

release/0.5.0 #284

release/0.5.0 #284

Conversation

thescientist13 commented Jan 29, 2020 • edited Loading

Related Issue

Summary of Changes

Breaking Changes

TODO

Nice To Have

Questions / Thoughts

thescientist13 left a comment • edited Loading

Choose a reason for hiding this comment

thescientist13 left a comment • edited Loading

Choose a reason for hiding this comment

thescientist13 Apr 22, 2020

Choose a reason for hiding this comment

thescientist13 Apr 22, 2020

Choose a reason for hiding this comment

hutchgrant Apr 22, 2020 • edited Loading

Choose a reason for hiding this comment

thescientist13 Apr 22, 2020

Choose a reason for hiding this comment

thescientist13 commented Apr 24, 2020

thescientist13 commented Jan 29, 2020 •

edited

Loading

thescientist13 left a comment •

edited

Loading

thescientist13 left a comment •

edited

Loading

hutchgrant Apr 22, 2020 •

edited

Loading