Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade and support LTS version of NodeJS (>= 12.x) #448

Closed
1 of 7 tasks
thescientist13 opened this issue Dec 16, 2020 · 1 comment · Fixed by #486
Closed
1 of 7 tasks

upgrade and support LTS version of NodeJS (>= 12.x) #448

thescientist13 opened this issue Dec 16, 2020 · 1 comment · Fixed by #486
Assignees
@thescientist13
Labels
alpha.7 CLI enhancement Improve something existing (e.g. no docs, new APIs, etc) P0 Critical issue that should get addressed ASAP v0.10.0
Milestone
No Bundle Feature...

Comments

@thescientist13
Copy link
Member

thescientist13 commented Dec 16, 2020 •
edited
Loading

Type of Change

  • New Feature Request
  • Documentation / Website
  • Improvement / Suggestion
  • Bug
  • Other (please clarify below)

Summary

As a project that relies heavily on the NodeJS ecosystem, we should make sure we stay relatively up to date with what's out there, especially as of Node v12, where more work has been introduced around Promised based APIs and better support for ESM, we should try and capture a minimum version, which as of now, I think should be v12, but maybe with a flag? I don't think unflagged ESM came until v14?

https://nodejs.org/en/about/releases/
Screen Shot 2020-12-16 at 8 25 57 AM

Details

We would need to

  1. Update .github/ workflows matrix
  2. Add an engines field to package.json
@thescientist13 thescientist13 changed the title upgrade and support LTS version of NodeJS upgrade and support LTS version of NodeJS (>= 12.x) Dec 16, 2020
@thescientist13 thescientist13 added CLI enhancement Improve something existing (e.g. no docs, new APIs, etc) labels Dec 24, 2020
@thescientist13 thescientist13 added this to the MVP milestone Dec 24, 2020
@thescientist13 thescientist13 added the P0 Critical issue that should get addressed ASAP label Feb 6, 2021
@thescientist13
Copy link
Member Author

thescientist13 commented Feb 23, 2021 •
edited
Loading

By this point, should we just consider going right to v14?
https://twitter.com/jasnell/status/1363976873328275459

Could see us jumping to v12 just to get 0.10.0 out, then v14 for the actual 1.0.0 release?

@thescientist13 thescientist13 mentioned this issue Feb 28, 2021
Merged
@thescientist13 thescientist13 linked a pull request Feb 28, 2021 that will close this issue
set node v12 as minimum version #486
Merged
@thescientist13 thescientist13 self-assigned this Feb 28, 2021
@thescientist13 thescientist13 mentioned this issue Mar 5, 2021
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thescientist13 thescientist13

Labels
alpha.7 CLI enhancement Improve something existing (e.g. no docs, new APIs, etc) P0 Critical issue that should get addressed ASAP v0.10.0
Projects
None yet
Milestone
No Bundle Feature Parity
Development

Successfully merging a pull request may close this issue.

set node v12 as minimum version ProjectEvergreen/greenwood
1 participant
@thescientist13