Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set node v12 as minimum version #486

Merged
merged 2 commits into from
Mar 5, 2021
Merged

set node v12 as minimum version #486

merged 2 commits into from
Mar 5, 2021

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Feb 28, 2021 •
edited
Loading

Related Issue

resolves #448

Summary of Changes

  1. Sets minimum Node.js version to v12, and added v14 as canary for CI
  2. Updated CI / docs

As part of #418, would like to get the minimum version fo v14 (for better ESM and native Promises support) for the eventual 1.0.0 release

@thescientist13 thescientist13 added enhancement Improve something existing (e.g. no docs, new APIs, etc) CLI labels Feb 28, 2021
@thescientist13 thescientist13 added P0 Critical issue that should get addressed ASAP chore unit testing, maintenance, etc documentation Greenwood specific docs labels Feb 28, 2021
@thescientist13 thescientist13 linked an issue Feb 28, 2021 that may be closed by this pull request
upgrade and support LTS version of NodeJS (>= 12.x) #448
Closed
7 tasks
@thescientist13 thescientist13 merged commit f4d6ede into release/0.10.0 Mar 5, 2021
@thescientist13 thescientist13 deleted the enhancement/issue-448-node-12-minumum-version branch March 5, 2021 22:12
thescientist13 added a commit that referenced this pull request Apr 3, 2021
@thescientist13
set node v12 as minimum version (#486)
2269937
thescientist13 added a commit that referenced this pull request Apr 3, 2021
@thescientist13
set node v12 as minimum version (#486)
2e51816
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hutchgrant hutchgrant Awaiting requested review from hutchgrant

@aholtzman aholtzman Awaiting requested review from aholtzman

Assignees
No one assigned
Labels
chore unit testing, maintenance, etc CLI documentation Greenwood specific docs enhancement Improve something existing (e.g. no docs, new APIs, etc) P0 Critical issue that should get addressed ASAP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

upgrade and support LTS version of NodeJS (>= 12.x)
1 participant
@thescientist13