Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch to c8 for ESM code coverage #818

Merged
merged 3 commits into from
Dec 9, 2021
Merged

switch to c8 for ESM code coverage #818

merged 3 commits into from
Dec 9, 2021

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Dec 8, 2021 •
edited

Related Issue

#532

Summary of Changes

  1. Switch to c8 for ESM based coverage, as it seems nyc is unable to support this at the moment

Bonus: looks like our code coverage went up with this tool! I guess I can recalibrate our watermarks. 🙌

# before
# https://github.com/ProjectEvergreen/greenwood/runs/4425333538?check_suite_focus=true
=============================== Coverage summary ===============================
Statements   : 85.6% ( 1641/1917 )
Branches     : 79.16% ( 733/926 )
Functions    : 86.36% ( 342/396 )
Lines        : 85.55% ( 1628/1903 )
================================================================================

# after
# https://github.com/ProjectEvergreen/greenwood/runs/4461384342?check_suite_focus=true
=============================== Coverage summary ===============================
Statements   : 87.93% ( 4302/4892 )
Branches     : 88.71% ( 841/948 )
Functions    : 93.68% ( 193/206 )
Lines        : 87.93% ( 4302/4892 )
================================================================================

@thescientist13 thescientist13 added the chore unit testing, maintenance, etc label Dec 8, 2021
@thescientist13 thescientist13 added this to the 1.0 milestone Dec 8, 2021
@thescientist13 thescientist13 linked an issue Dec 8, 2021 that may be closed by this pull request
Upgrade project codebase to ESM #532
Closed
5 tasks
@thescientist13 thescientist13 mentioned this pull request Dec 8, 2021
Merged
20 tasks
@thescientist13 thescientist13 merged commit b8fb24f into release/0.20.0 Dec 9, 2021
@thescientist13 thescientist13 deleted the chore/issue-532-restore-code-coverage-for-esm branch December 9, 2021 16:19
@thescientist13 thescientist13 moved this from IN REVIEW to DONE in 7 - SSR and External Data Sources Dec 9, 2021
thescientist13 added a commit that referenced this pull request Dec 9, 2021
@thescientist13
switch to c8 for ESM code coverage (#818)
ba23cf9 
* switch to c8 for ESM code coverage

* set new thresholds
thescientist13 added a commit that referenced this pull request Dec 18, 2021
@thescientist13
switch to c8 for ESM code coverage (#818)
5f69e3e 
* switch to c8 for ESM code coverage

* set new thresholds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
alpha.1 chore unit testing, maintenance, etc v0.20.0
Projects
No open projects
7 - SSR and External Data Sources
DONE
Milestone
1.0
Development

Successfully merging this pull request may close these issues.

Upgrade project codebase to ESM
1 participant
@thescientist13