Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brightness / Contrast plugin #1985

Closed
camillevilla opened this issue Feb 27, 2019 · 5 comments
Closed

Brightness / Contrast plugin #1985

camillevilla opened this issue Feb 27, 2019 · 5 comments
Assignees

Comments

@camillevilla
Copy link
Member

We want to use this as an opportunity for testing out plugin architecture.

  • Not in projectmirador/mirador repo
@jvine
Copy link
Collaborator

jvine commented Mar 23, 2019

plugin menu adjust

  • add "Adjust image" option to the window menu, in the section below view/thumbnails
  • on select, close the menu and open the "Adjust image" toolbar
  • toolbar is horizontal above the mobile breakpoint; vertical below it
    • note that we may want a configuration option to set the default orientation for the toolbar - manuscripts with vertical text will prefer a vertical toolbar that doesn't cut off the first character of each column
  • toolbar has its own close button
  • icon tooltips appear below or to the left, depending on the orientation of the toolbar
  • toolbar pattern is meant be used for other tools & plugins as well - annotations, ruler, etc.

The illustrated set of icons represents what's implemented in Mirador2:
Screen Shot 2019-03-22 at 6 40 05 PM

Partial implementation with Brightness/Contrast alone would look like so:
Screen Shot 2019-03-22 at 6 28 45 PM

Tooltip Icon (MUI name)
Adjust image (menu option) tune
Brightness brightness_5
Contrast custom (ask @jvine for this one)
Greyscale tonality (different from mockups)
Invert colors invert_colors
Rotate right rotate_right
Rotate left rotate_left
Flip horizontal compare_arrows
Flip vertical compare_arrows rotated
Revert image refresh
Close toolbar close

@jvine jvine removed their assignment Mar 25, 2019
@mejackreed mejackreed self-assigned this Apr 10, 2019
@mejackreed
Copy link
Collaborator

I started working on this https://github.com/mejackreed/mirador-image-tools however, I think its blocked until we can resolve the "Where does the PluginHook thing happen for all the things?" question.

@mejackreed
Copy link
Collaborator

Ok so updates.. I've moved the repo here: https://github.com/projectmirador/mirador-image-tools

Will start creating spin off tickets there and here to move work/plugins forward.

@mejackreed
Copy link
Collaborator

@mejackreed
Copy link
Collaborator

Closing this issue as "done for now" as a proof of concept of the plugin and plugin system has been completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants