New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronous XMLHTTPRequest deprecated in chrome. #388

Closed
aeschylus opened this Issue Jan 23, 2015 · 6 comments

Comments

Projects
None yet
4 participants
@aeschylus
Collaborator

aeschylus commented Jan 23, 2015

Newest chrome has deprecated all synchronous ajax requests (for good reason). Mirador is now complaining about them. We shouldn't have any of these anyway, so we'll see where they're hiding. Find them and destroy them.

@aeschylus aeschylus added the bug label Jan 23, 2015

@aeschylus aeschylus self-assigned this Jan 23, 2015

@aeschylus aeschylus added this to the Layout Interface milestone Jan 23, 2015

pobocks added a commit to harvard-library/m2 that referenced this issue Jan 29, 2015

@pobocks

This comment has been minimized.

Show comment
Hide comment
@pobocks

pobocks Jan 29, 2015

Contributor

Hello, this is Dave from HUIT -> LTS.

I'm working on familiarizing myself with the code base, and am doing so partly through picking off low-hanging fruit from the issue queue. Feel free to ignore the PR if it's not useful/duplicates effort.

Contributor

pobocks commented Jan 29, 2015

Hello, this is Dave from HUIT -> LTS.

I'm working on familiarizing myself with the code base, and am doing so partly through picking off low-hanging fruit from the issue queue. Feel free to ignore the PR if it's not useful/duplicates effort.

@aeschylus

This comment has been minimized.

Show comment
Hide comment
@aeschylus

aeschylus Jan 29, 2015

Collaborator

Thanks for the contribution. I will pull it down and have a look. The diff looks pretty straightforward.

If you're looking to familiarise yourself with the codebase, a great place to start is with the mirador.js file. That is our entry point (fired off when the page loads/Mirador({...}) is called. Everything spiders down from there.

Most of our requests are done using promises/deferred objects, but not all of them have been migrated to that pattern.

Thanks for your interest, and I look forward to merging this pull request.

Collaborator

aeschylus commented Jan 29, 2015

Thanks for the contribution. I will pull it down and have a look. The diff looks pretty straightforward.

If you're looking to familiarise yourself with the codebase, a great place to start is with the mirador.js file. That is our entry point (fired off when the page loads/Mirador({...}) is called. Everything spiders down from there.

Most of our requests are done using promises/deferred objects, but not all of them have been migrated to that pattern.

Thanks for your interest, and I look forward to merging this pull request.

@pobocks

This comment has been minimized.

Show comment
Hide comment
@pobocks

pobocks Jan 29, 2015

Contributor

I left getJsonFromUrl and its tests around because I think there's an issue with the tests which could show up in other places. I'm writing an issue for that, and will reference this PR there.

Contributor

pobocks commented Jan 29, 2015

I left getJsonFromUrl and its tests around because I think there's an issue with the tests which could show up in other places. I'm writing an issue for that, and will reference this PR there.

@rsinghal

This comment has been minimized.

Show comment
Hide comment
@rsinghal

rsinghal May 19, 2016

Collaborator

At least one culprit is i18next. We force the resource file to load asynchronously or the translations won't be fully loaded before the dom elements are populated. Doing #935 should give us the option to handle the loading of the resource file differently, using one of these backends: http://i18next.com/docs/ecosystem/#plugins

Collaborator

rsinghal commented May 19, 2016

At least one culprit is i18next. We force the resource file to load asynchronously or the translations won't be fully loaded before the dom elements are populated. Doing #935 should give us the option to handle the loading of the resource file differently, using one of these backends: http://i18next.com/docs/ecosystem/#plugins

@aeschylus

This comment has been minimized.

Show comment
Hide comment
@aeschylus

aeschylus May 19, 2016

Collaborator

My pr fixed that. #920

#920 (comment)
Do you want to re-open and I can merge your approach to the dev/GB issue, then we can integrate it into 2.1?

Collaborator

aeschylus commented May 19, 2016

My pr fixed that. #920

#920 (comment)
Do you want to re-open and I can merge your approach to the dev/GB issue, then we can integrate it into 2.1?

@rsinghal

This comment has been minimized.

Show comment
Hide comment
@rsinghal

rsinghal May 20, 2016

Collaborator

I didn't realize you had also changed viewer.js - thought you just added the new files. I think you already merged my PR with the extra settings, so I'm just going to submit a new PR with your changes to viewer.js.

Collaborator

rsinghal commented May 20, 2016

I didn't realize you had also changed viewer.js - thought you just added the new files. I think you already merged my PR with the extra settings, so I'm just going to submit a new PR with your changes to viewer.js.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment