-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Synchronous XMLHTTPRequest deprecated in chrome. #388
Comments
…ynchronous jQuery.getJSON calls.
Hello, this is Dave from HUIT -> LTS. I'm working on familiarizing myself with the code base, and am doing so partly through picking off low-hanging fruit from the issue queue. Feel free to ignore the PR if it's not useful/duplicates effort. |
Thanks for the contribution. I will pull it down and have a look. The diff looks pretty straightforward. If you're looking to familiarise yourself with the codebase, a great place to start is with the Most of our requests are done using promises/deferred objects, but not all of them have been migrated to that pattern. Thanks for your interest, and I look forward to merging this pull request. |
I left getJsonFromUrl and its tests around because I think there's an issue with the tests which could show up in other places. I'm writing an issue for that, and will reference this PR there. |
At least one culprit is i18next. We force the resource file to load asynchronously or the translations won't be fully loaded before the dom elements are populated. Doing #935 should give us the option to handle the loading of the resource file differently, using one of these backends: http://i18next.com/docs/ecosystem/#plugins |
My pr fixed that. #920 #920 (comment) |
I didn't realize you had also changed viewer.js - thought you just added the new files. I think you already merged my PR with the extra settings, so I'm just going to submit a new PR with your changes to viewer.js. |
Newest chrome has deprecated all synchronous ajax requests (for good reason). Mirador is now complaining about them. We shouldn't have any of these anyway, so we'll see where they're hiding. Find them and destroy them.
The text was updated successfully, but these errors were encountered: