Modify JsonLd.getTextValue to match algorithm outlined in spec #1133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbaiter
changed the title
JsonLd.getTextValue to match algorithm outlined in spec
|
@jbaiter Can you switch this PR to |
|
This looks good to me, but we need to rebase to 2.1.1. |
jbaiter
force-pushed
the
multilang-propval
branch
from
b4f17d7
to
2a2a86f
Compare
jbaiter
force-pushed
the
multilang-propval
branch
from
2a2a86f
to
8758bb3
Compare
|
Done :-) |
rsinghal
approved these changes
Oct 18, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the algorithm outlined in "4.3. Language of Property Values" in the Presentation API 2.1 specification.
It maintains complete backwards compatibility with existing code (as far as I could tell from the unit tests).
In the present implementation the browser's language preferences (as available from
window.navigator.languages) are used, although the language(s) passed toMirador.JsonLd.getTextValuealways take precedence over these.