Fix (partial) 1143 - Disabling annotation layer mouse mouse handlers in default mode #1200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because otherwise mouse events keep firing in default mode when they shouldn't.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a partial fix to #1143
Mouse tool for the paperScope was still triggering mouse handlers when the canvas is hidden, making "drag and select" of texts unresponsive. This change explicitly deletes the mouseTool when entering the "default" mode and creates one when entering "pointer" mode.
This is not a complete fix in that
(1) While you can drag and select in default mode, you still cannot in pointer and edit modes. It is probably impossible to fix because of the way paper.js manages events
(2) It is could possibly a Chrome bug rather, because the problem is not occurring in FireFox or Safari.