Configurable language

[morpheus-87]

This PR makes the language of the UI configurable in the init step.

[coveralls]

Coverage increased (+0.01%) to 61.797% when pulling a3f3eaa on dbmdz:feature/configurable-language into b4248b4 on ProjectMirador:2.1.3.

[coveralls]

Coverage increased (+0.01%) to 61.797% when pulling 9e223d3 on dbmdz:feature/configurable-language into 099324d on ProjectMirador:2.1.3.

[coveralls]

Coverage increased (+0.01%) to 61.474% when pulling 7f0eb4c on dbmdz:feature/configurable-language into 993b08e on ProjectMirador:2.1.4.

[aeschylus]

This has some conflicts with the improvements from one of your other PRs. Also, there is another way to implement configuration which is used in other areas of the app, so can you resubmit this as a new PR with that pattern?

A good example can be found by looking at the saveController.js and the DEFAULT_SETTINGS in settings.js

Marking as wontfix for now, but open to a revised PR.

[morpheus-87]

I checked your change request and saw, that there is no other way to get configuration parameters in viewer.js except reading it from the state.

It seems, that the behaviour you are talking about, was removed in commit d0f6310 by @rsinghal.

[rsinghal]

That's the correct way to get information from the configuration @aeschylus. Not sure what you are looking for?

[aeschylus]

Sorry, was closing like 12 PRs simultaneously and don't think I grasped what this was trying to do. If you need to get the configuration dynamically (rather than on initialisation of the whole App using extend), this makes sense.

Can you settle the conflict in viewer.js and we can merge from there?

[coveralls]

Coverage increased (+0.05%) to 61.7% when pulling e27cd27 on dbmdz:feature/configurable-language into ea2a0a5 on ProjectMirador:2.3.0.

[morpheus-87]

In the meantime, I fixed the conflict, @aeschylus.

I would like to add a testcase for this functionality, what would be the best place to do this?

[aeschylus]

Looks like viewer.js is still a stub, but that would be the place I think. You would need to test that the language was one thing in the config before the runtime initialisation.

Thanks for fixing this up. Looking forward to merging.

[coveralls]

Coverage increased (+0.01%) to 61.559% when pulling 40cfdd5 on dbmdz:feature/configurable-language into 2d7c9cb on ProjectMirador:2.3.0.

[morpheus-87]

Is it really necessary to have a separate testcase for setting the language, @aeschylus?

[aeschylus]

@morpheus-87 Always a fair question. I think it could be useful since it's happening at runtime. Can one of us help set up the test case?

[coveralls]

Coverage increased (+0.01%) to 62.037% when pulling 09bbf69 on dbmdz:feature/configurable-language into 4522310 on ProjectMirador:2.3.0.

[coveralls]

Coverage increased (+0.01%) to 62.037% when pulling 05401c9 on dbmdz:feature/configurable-language into 50b1730 on ProjectMirador:2.3.0.

[morpheus-87]

Would be great, if somebody could help me with setting up the test case.

[coveralls]

Coverage increased (+0.07%) to 62.117% when pulling 90239ea on dbmdz:feature/configurable-language into 37c3062 on ProjectMirador:2.3.0.

[coveralls]

Coverage increased (+0.01%) to 62.059% when pulling 4a102f7 on dbmdz:feature/configurable-language into 632bcce on ProjectMirador:2.4.0.

[morpheus-87]

Could somebody help me with setting up the test case?

[coveralls]

Coverage increased (+0.01%) to 62.059% when pulling b5eabe6 on dbmdz:feature/configurable-language into 2d4a908 on ProjectMirador:2.4.0.

[coveralls]

Coverage increased (+0.01%) to 62.059% when pulling 4bc0e04 on dbmdz:feature/configurable-language into 537b037 on ProjectMirador:2.4.0.

[coveralls]

Coverage increased (+0.01%) to 62.027% when pulling 69c72e7 on dbmdz:feature/configurable-language into bf3eb06 on ProjectMirador:develop.

[coveralls]

Coverage decreased (-0.05%) to 61.972% when pulling 451ccb7 on dbmdz:feature/configurable-language into 529380b on ProjectMirador:develop.

[rsinghal]

@morpheus-87 Hopefully this will help you set up the tests:

https://github.com/ProjectMirador/mirador/blob/detail_images_and_image_choice/spec/widgets/sidePanel.test.js

Specifically, this is to create a skeleton config: https://github.com/ProjectMirador/mirador/blob/detail_images_and_image_choice/spec/widgets/sidePanel.test.js#L17

And then this actually tests something that is in the config: https://github.com/ProjectMirador/mirador/blob/detail_images_and_image_choice/spec/widgets/sidePanel.test.js#L102

[coveralls]

Coverage increased (+0.06%) to 62.027% when pulling 94e8994 on dbmdz:feature/configurable-language into 52b572e on ProjectMirador:develop.

[coveralls]

Coverage decreased (-0.05%) to 61.972% when pulling 528beea on dbmdz:feature/configurable-language into 4cfa692 on ProjectMirador:develop.

[coveralls]

Coverage increased (+0.02%) to 72.537% when pulling 96b3df2 on dbmdz:feature/configurable-language into 918a539 on ProjectMirador:develop.

[morpheus-87]

I just updated the branch and set up a testcase in spec/mirador.test.js.

[coveralls]

Coverage increased (+0.1%) to 72.618% when pulling f8ed3d0 on dbmdz:feature/configurable-language into 9ae2cf9 on ProjectMirador:develop.

[aeschylus]

Thanks @morpheus-87. This looks good to me.