Patch for issue 1549. Book View incorrect for R-to-L Manuscripts. #1550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that viewingDirection was not passed to BookView so it was defaulting to L-to-R behaviour. Although 'vDirectionStatus' was used in parts.
The indexing seems to assume that the current index would begin at 0 on the right hand side, but it begun at the last index (so it would error for documents with an odd length).
Instead I have used a adjusted index for right-to-left mode to work out the odd/even case that behaves as expected (right starts from 0 in R-to-L mode).