Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export more unconnected components #1634

Merged
merged 2 commits into from Jan 17, 2019
Merged

Export more unconnected components #1634

merged 2 commits into from Jan 17, 2019

Conversation

jbaiter
Copy link
Collaborator

@jbaiter jbaiter commented Jan 16, 2019 •
edited

  • App
  • ManifestForm
  • ManifestListItem
  • OpenSeadragonViewer
  • WindowTopBarButtons
  • WindowTopBar

@jbaiter jbaiter force-pushed the 1611-export-more-unconnected branch from 8e46d6a to cec58f1 Compare January 16, 2019 23:03
@jkeck jkeck mentioned this pull request Jan 16, 2019
Closed
22 tasks
@jbaiter jbaiter requested a review from jkeck January 17, 2019 00:56
@mejackreed
Copy link
Collaborator

I just updated the CodeClimate settings from "Enforce Diff Coverage" to "Enforce Total Coverage"

Because the code was moved, CC seemed to think they were "new lines".

@mejackreed mejackreed merged commit 48f5e65 into master Jan 17, 2019
@mejackreed mejackreed deleted the 1611-export-more-unconnected branch January 17, 2019 16:27
@camillevilla camillevilla mentioned this pull request Jan 24, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charbugs charbugs charbugs approved these changes

@jkeck jkeck Awaiting requested review from jkeck

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jbaiter @mejackreed @charbugs