Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a title to the mirador icon #3011

Merged
merged 1 commit into from May 8, 2020
Merged

Add a title to the mirador icon #3011

merged 1 commit into from May 8, 2020

Conversation

cbeer
Copy link
Collaborator

@cbeer cbeer commented May 8, 2020

Fixes #2934

@codecov-io
Copy link

codecov-io commented May 8, 2020

Codecov Report

Merging #3011 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3011   +/-   ##
=======================================
  Coverage   93.01%   93.01%           
=======================================
  Files         167      167           
  Lines        2705     2705           
=======================================
  Hits         2516     2516           
  Misses        189      189           
Impacted Files Coverage Δ
src/components/icons/MiradorIcon.js 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0789034...209f8bd. Read the comment docs.

Copy link
Collaborator

@mejackreed mejackreed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we provide a titleAccess prop to the SvgIcon component instead where we use that? That way this Icon could be reusable without having to carry this title in the svg?

https://material-ui.com/api/svg-icon/#props

Copy link
Collaborator

@mejackreed mejackreed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mejackreed mejackreed merged commit a8d5acc into master May 8, 2020
@mejackreed mejackreed deleted the 2934-mirador-title branch May 8, 2020 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mirador logo link needs link text
3 participants