Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring components to avoid pulling in manifesto canvas objects where possible #3262

Merged
merged 4 commits into from Sep 21, 2020

Conversation

cbeer
Copy link
Collaborator

@cbeer cbeer commented Sep 21, 2020

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Sep 21, 2020

Codecov Report

Merging #3262 into master will decrease coverage by 0.04%.
The diff coverage is 89.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3262      +/-   ##
==========================================
- Coverage   89.30%   89.26%   -0.05%     
==========================================
  Files         190      191       +1     
  Lines        3292     3306      +14     
==========================================
+ Hits         2940     2951      +11     
- Misses        352      355       +3     
Impacted Files Coverage Δ
src/components/LayersPanel.js 100.00% <ø> (ø)
src/components/SidebarIndexItem.js 100.00% <ø> (ø)
src/components/SidebarIndexList.js 83.33% <ø> (-2.39%) ⬇️
src/components/SidebarIndexThumbnail.js 100.00% <ø> (ø)
src/components/WindowSideBarAnnotationsPanel.js 80.00% <ø> (ø)
src/components/IIIFThumbnail.js 88.23% <82.35%> (-3.66%) ⬇️
src/components/CanvasLayers.js 98.03% <100.00%> (ø)
src/components/ThumbnailCanvasGrouping.js 93.33% <100.00%> (ø)
src/components/ThumbnailNavigation.js 97.18% <100.00%> (ø)
src/components/WindowSideBarInfoPanel.js 80.00% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e30a6b9...5b6a165. Read the comment docs.

@mejackreed mejackreed merged commit 430361d into master Sep 21, 2020
@mejackreed mejackreed deleted the refactoring-canvases branch September 21, 2020 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants