Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tReady from WindowList props #3890

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lutzhelm
Copy link
Contributor

This change just removes the console warning about passing tReady (which is passed as prop via withTranslation()) as a property to a DOM element. We don't do something like that in WindowList directly, and all components within WindowList are from MUI, so there might be a MUI component passing all props to a native element. There might also be more occurrences of that issue in other components.

I'm neither sure if this is even noticable in non-dev builds nor if we should file this as an issue with MaterialUI.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (593e81b) 92.53% compared to head (59bdef9) 92.54%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3890   +/-   ##
=======================================
  Coverage   92.53%   92.54%           
=======================================
  Files         203      203           
  Lines        3579     3580    +1     
=======================================
+ Hits         3312     3313    +1     
  Misses        267      267           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants