Remove tReady from WindowList props #3890
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change just removes the console warning about passing
tReady
(which is passed as prop viawithTranslation()
) as a property to a DOM element. We don't do something like that inWindowList
directly, and all components withinWindowList
are from MUI, so there might be a MUI component passing all props to a native element. There might also be more occurrences of that issue in other components.I'm neither sure if this is even noticable in non-dev builds nor if we should file this as an issue with MaterialUI.