Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use zone returned by buildOffer when creating collection offers. #1058

Merged
merged 1 commit into from
Jun 30, 2023
Merged

Use zone returned by buildOffer when creating collection offers. #1058

merged 1 commit into from
Jun 30, 2023

Conversation

thenerdassassin
Copy link
Contributor

Motivation

Using the default zone (zero address) was causing the collection offer orders to fail.

Solution

Instead, use the zone returned by the builder endpoint.

@thenerdassassin thenerdassassin requested a review from a team June 30, 2023 02:54
sunwrobert
sunwrobert approved these changes Jun 30, 2023
View reviewed changes
Copy link
Collaborator

@sunwrobert sunwrobert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. we actually expose a offer_protection_enabled flag that we could add in a future version so people can choose whether or not they want to use the zone. can be done later though

@thenerdassassin thenerdassassin merged commit 876845a into main Jun 30, 2023
8 checks passed
@thenerdassassin thenerdassassin deleted the collectionOfferZoneBugFix branch June 30, 2023 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunwrobert sunwrobert sunwrobert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thenerdassassin @sunwrobert