Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use zone returned by buildOffer when creating collection offers. #1058

Merged
merged 1 commit into from
Jun 30, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "opensea-js",
"version": "6.0.5",
"version": "6.0.6",
"description": "JavaScript SDK for the OpenSea marketplace helps developers build new experiences using NFTs and our marketplace data!",
"license": "MIT",
"author": "OpenSea Developers",
Expand All @@ -18,17 +18,17 @@
"src"
],
"scripts": {
"postinstall": "husky install || exit 0",
"prepare": "npm run build",
"abi-type-gen": "typechain --target=ethers-v5 src/abi/*.json --out-dir=src/typechain/contracts",
"build": "npm run abi-type-gen && tsc -p tsconfig.build.json && npm run bundle",
"bundle": "browserify lib/index.js -o lib/bundle.js",
"abi-type-gen": "typechain --target=ethers-v5 src/abi/*.json --out-dir=src/typechain/contracts",
"check-types": "tsc --noEmit --project tsconfig.json",
"coverage-report": "nyc report --reporter=lcov",
"docs-build": "typedoc --out docs src/index.ts",
"lint": "concurrently \"npm run check-types\" \"npm run prettier:check\" \"npm run eslint:check\"",
"eslint:check": "eslint . --max-warnings 0 --ext .js,.ts",
"eslint:fix": "npm run eslint:check -- --fix",
"postinstall": "husky install || exit 0",
"lint": "concurrently \"npm run check-types\" \"npm run prettier:check\" \"npm run eslint:check\"",
"prepare": "npm run build",
"prettier:check": "prettier --check .",
"prettier:check:package.json": "prettier-package-json --list-different",
"prettier:fix": "prettier --write .",
Expand Down
4 changes: 2 additions & 2 deletions src/sdk.ts
Original file line number Diff line number Diff line change
Expand Up @@ -572,10 +572,10 @@ export class OpenSeaSDK {
endTime:
expirationTime?.toString() ??
getMaxOrderExpirationTimestamp().toString(),
zone: DEFAULT_ZONE_BY_NETWORK[this.chain],
zone: buildOfferResult.partialParameters.zone,
domain,
salt: BigNumber.from(salt ?? 0).toString(),
restrictedByZone: false,
restrictedByZone: true,
allowPartialFills: true,
};

Expand Down