Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix running tests in Windows dev env #1142

Merged
merged 1 commit into from
Aug 8, 2023
Merged

Fix running tests in Windows dev env #1142

merged 1 commit into from
Aug 8, 2023

Conversation

ryanio
Copy link
Collaborator

@ryanio ryanio commented Aug 8, 2023

Fixes #1135

@ryanio ryanio requested a review from a team August 8, 2023 15:26
@ryanio ryanio mentioned this pull request Aug 8, 2023
Closed
sambarnes
sambarnes approved these changes Aug 8, 2023
View reviewed changes
Copy link
Contributor

@sambarnes sambarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

think its worth making a ticket to track cross-platform testing in CI?

@ryanio
Copy link
Collaborator Author

ryanio commented Aug 8, 2023

good callout but tbh i think it's fine for now, we can just fix ad hoc when users report any issues they face

@mchmatt
Copy link

mchmatt commented Aug 8, 2023

Can confirm my issue (#1135) was fixed with this PR, ty!

@ryanio ryanio merged commit 6ba6a1d into main Aug 8, 2023
8 checks passed
@ryanio ryanio deleted the ryan/fix-windows-dev branch August 8, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sambarnes sambarnes sambarnes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tests (general and integration) scripts are platform dependent and won't run in Windows
3 participants
@ryanio @mchmatt @sambarnes