Skip to content
This repository has been archived by the owner on Sep 1, 2023. It is now read-only.

Blocking token owners #5

Closed
cxkoda opened this issue Nov 7, 2022 · 2 comments
Closed

Blocking token owners #5

cxkoda opened this issue Nov 7, 2022 · 2 comments

Comments

@cxkoda
Copy link
Contributor

cxkoda commented Nov 7, 2022

The current implementation of the operator filtering logic allows token owners (also real users) to be blocked indefinitely from moving their tokens. See also #4 for a failing test.

Was this intentional? If so, what was the reasoning for it?
Even though it is the contract owners decision in the end to leave this in, I think this should not be allowed in the reference implementation.

@cxkoda
Copy link
Contributor Author

cxkoda commented Nov 8, 2022

It was stated that new collections will be required to implement the proposed operator filtering if creators want to receive any royalties from OS.
Does this mean that developers have to implement it like in the reference example? So including the ability to lock out token owner?

@operatorfilterer
Copy link
Collaborator

Fixed with your PR #4 - thanks!

We only check that the mandatory list of operators are blocked from transferring - implementation does not matter.

emo-eth added a commit that referenced this issue Jan 20, 2023
OpenZeppelin L-01: Examples lack EIP-2981 implementation
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants