Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update forge-std, remove now-included makeAccount #1221

Merged
merged 7 commits into from
May 11, 2023
Merged

Conversation

ryanio
Copy link
Contributor

@ryanio ryanio commented May 5, 2023

No description provided.

@ryanio
Copy link
Contributor Author

ryanio commented May 5, 2023

would love some help figuring out what's going wrong with the 1271 forge tests, since I'm importing seaport into seadrop I'm getting errors with makeAccount now being available in latest forge-std lib, i can confirm this PR fixes the downstream issue I'm facing

@codecov-commenter
Copy link

codecov-commenter commented May 10, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (55d2dc6) 99.96% compared to head (d09a41b) 99.96%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1221   +/-   ##
=======================================
  Coverage   99.96%   99.96%           
=======================================
  Files          47       47           
  Lines        2689     2689           
  Branches      396      396           
=======================================
  Hits         2688     2688           
  Misses          1        1           
Flag Coverage Δ
foundry 78.04% <ø> (-0.05%) ⬇️
production 100.00% <ø> (ø)
reference 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@0age 0age merged commit 4c9faf1 into main May 11, 2023
@ryanio ryanio deleted the ryan/update-forge-std branch April 16, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants