Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Begins to fix #2485
We are now recording a lot more metadata about the panoramas that we're using. This also fixes incorrect recording of the metadata that we had been doing in the past. Here's a list of changes:
image_width
,image_height
,tile_width
, andtile_height
in thegsv_data
table. We had previously been recording hard coded values of 13312, 6656, 512, and 512 respectively, but these are not actually constant across all panoramas. Going forward, we are recording the correct values from the StreetView API. I've marked all previous data asNULL
, and I'm hoping that we can write a script to correct the metadata for the imagery that is still available.center_heading
,origin_heading
, andorigin_pitch
in thegsv_data
table. I'm not sure whether or not these will be useful, but it's data that's available, so it's worth recording.imagery_type
column from thegsv_data
table. This column was being given a hard-coded value of 1 everywhere. There was also no key for what that value means anywhere, so this column had no purpose./adminapi/labels/panoid
API endpoint to include theimage_width
andimage_height
values. I also simplified the JSON output for this endpoint. Previously it was set up as a Feature Collection in GeoJSON, but there's actually no geographic info being included here. So we are now simply outputting an array of objects./adminapi/labels/panoid
to/adminapi/panos
because that's a more accurate naming. Both endpoints point to the same thing for now. Once all our external tools switch to the new name, I can remove the old one.Before/After screenshots (if applicable)
Before:
After:
Things to check before submitting the PR