Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import/Export world and rework MyLearningWorldsOverview #443

Merged
merged 26 commits into from
Dec 12, 2023
Merged

Conversation

niklasstich
Copy link
Member

Closes #367
Closes #368
Closes #425
Fixes #252

@niklasstich niklasstich self-assigned this Nov 29, 2023
@niklasstich niklasstich added bug Something isn't working enhancement New feature or request labels Nov 29, 2023
@coveralls
Copy link

coveralls commented Nov 29, 2023

Pull Request Test Coverage Report for Build 7181871646

  • 143 of 182 (78.57%) changed or added relevant lines in 18 files are covered.
  • 23 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.2%) to 89.3%

Changes Missing Coverage Covered Lines Changed/Added Lines %
Presentation/PresentationLogic/MyLearningWorlds/MyLearningWorldsProvider.cs 12 13 92.31%
BusinessLogic/ErrorManagement/DataAccess/HashExistsException.cs 2 4 50.0%
BusinessLogic/Commands/World/SaveLearningWorld.cs 6 9 66.67%
DataAccess/Extensions/ZipExtensions.cs 21 24 87.5%
Presentation/PresentationLogic/API/PresentationLogic.cs 4 7 57.14%
Presentation/View/MyLearningWorlds/MyLearningWorldsOverview.razor 21 25 84.0%
DataAccess/Persistence/LearningWorldSavePathsHandler.cs 8 13 61.54%
BusinessLogic/API/BusinessLogic.cs 1 7 14.29%
DataAccess/API/DataAccess.cs 32 38 84.21%
DataAccess/Persistence/ContentFileHandler.cs 2 8 25.0%
Files with Coverage Reduction New Missed Lines %
BusinessLogic/ErrorManagement/DataAccess/HashExistsException.cs 1 50.0%
Presentation/PresentationLogic/MyLearningWorlds/MyLearningWorldsProvider.cs 2 89.29%
Configuration/ApplicationPaths.cs 4 16.67%
DataAccess/Persistence/LearningWorldSavePathsHandler.cs 4 60.87%
Presentation/PresentationLogic/API/PresentationLogic.cs 12 90.42%
Totals Coverage Status
Change from base Build 7181331531: -0.2%
Covered Lines: 12068
Relevant Lines: 13514

💛 - Coveralls

# Conflicts:
#	Changelog.md
#	Presentation/PresentationLogic/API/IPresentationLogic.cs
#	PresentationTest/PresentationLogic/MyLearningWorlds/MyLearningWorldsProviderUt.cs
Updated ExportLearningWorldToArchive to use this new abstraction
Tested ExportLearningWorldToArchive
@niklasstich niklasstich marked this pull request as ready for review December 11, 2023 17:03
@niklasstich niklasstich merged commit 9104135 into main Dec 12, 2023
14 of 15 checks passed
@niklasstich niklasstich deleted the issue-367 branch December 12, 2023 13:21
MarvinHo64 added a commit that referenced this pull request Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
3 participants