Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to specify css className #4

Merged
merged 2 commits into from
Sep 5, 2019
Merged

add option to specify css className #4

merged 2 commits into from
Sep 5, 2019

Conversation

Chrissi2812
Copy link
Contributor

The only downside is that overriding the width or height via css will not work correctly (mention in documentation?)

Default is currently that it doesn't add any class when not specified.

@marijnh
Copy link
Member

marijnh commented Sep 5, 2019

Apologies for not responding to this forever. I didn't have notifications turned on for this repository.

If you're still interested in this, could you change the property name to just class and mention the feature in the readme?

@Chrissi2812
Copy link
Contributor Author

@marijnh No problem, had forgotten about it myself ^^
I made the requested changes.

@marijnh marijnh merged commit 35e276c into ProseMirror:master Sep 5, 2019
@Chrissi2812 Chrissi2812 deleted the add-css-class branch November 16, 2022 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants