Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Column resize handle appears in the wrong place #14

Closed
eshvedai opened this issue Oct 5, 2017 · 6 comments
Closed

Column resize handle appears in the wrong place #14

eshvedai opened this issue Oct 5, 2017 · 6 comments

Comments

@eshvedai
Copy link
Collaborator

eshvedai commented Oct 5, 2017

Browser
Firefox 54

ff-resize-handle

@marijnh
Copy link
Member

marijnh commented Oct 6, 2017

Going by your screencast, I opened the demo, added a column after the cell containing 'One', and then dragged the column border on the left of that new column. But I'm not seeing the problem occur (also using Firefox). Are you doing anything that's not easily seen in the screencast?

@eshvedai
Copy link
Collaborator Author

eshvedai commented Oct 7, 2017

This time I just opened the demo page and hovered over the first handle, it requires a bit of cursor movement by 1-2 pixels back and forth over the cell border to catch this.

If the handle is under the cursor, resizing works correctly. If it jumps to the right border of the next cell, I'm able to resize the next cell instead. (Firefox 54.0.1 (64-bit) Mac)

ff-drag-handle

@marijnh
Copy link
Member

marijnh commented Oct 7, 2017

Odd. I've been moving the mouse over the cell border, in that exact Firefox version on that exact platform, for five minutes, but haven't been able to reproduce the issue. Looking at the code (in handleMouseMove) I also can't spot anything that would lead to this behavior. One possibility is that view.posAtCoords in edgeCell returns an inaccurate result on your platform for some reason. But that's hard to debug if I can't observe it.

@eshvedai
Copy link
Collaborator Author

eshvedai commented Oct 8, 2017

you're right, seems like when I move the cursor from right to left over the handle, it jumps to the right when the target from handleMouseMove is cell "One" td DOM node, whereas posFromCaret -> desc.dom is still cell "Two", which means edgeCell side attribute becomes right when I still have an old $cell. I'll try to figure out how to fix it :)

@marijnh
Copy link
Member

marijnh commented Oct 12, 2017

One interesting piece of information would be what caretPositionFromPoint returns on your browser for the problematic coordinates. That's what posAtCoords is likely basing its result on, and if it's returning something strange, we'll have to somehow find a way to notice when this happens and correct it.

@eshvedai
Copy link
Collaborator Author

eshvedai commented Jan 4, 2018

Its working fine with Firefox 57, closing this until someone else will complain about having the same issue.

@eshvedai eshvedai closed this as completed Jan 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants